[elbe-devel] [PATCH 0/8] fix problems with licence generation

Bastian Germann bage at linutronix.de
Mon Oct 14 18:20:01 CEST 2019


> This queue fixes the following problem:
> 
> ---------------------------------------------------------------------------------------------------
> [ERROR] Error while processing license file                                                                                                          
> /var/cache/elbe/028a0461-fe6e-4263-a138-116c8ffd1c86/chroot/usr/share/doc/xorg/copyright                                                             
> Traceback (most recent call last):                                                                                                                   
>   File "/usr/lib/python2.7/dist-packages/elbepack/efilesystem.py", line                                                                              
> 146, in write_licenses                                                                                                                               
>     with io.open(os.path.join(d, "copyright"), "rb") as lic:                                                                                         
> IOError: [Errno 2] No such file or directory:                                                                                                        
> '/var/cache/elbe/028a0461-fe6e-4263-a138-116c8ffd1c86/chroot/usr/share/doc/xorg/copyright'               
> ---------------------------------------------------------------------------------------------------
> 
> The cause is that the xserver-xorg package contains /usr/share/doc/xorg
> directory, but no /usr/share/doc/xorg/copyright file.
> 
> Ignoring such an error is not an option here, because a missing licence
> file really is an error. 
> 
> Use the list of installed packages from the rpcaptcache, to generate the
> filenames. Clean up somewhat, and modify "elbe genlicence" so that the list
> of installed packages is now known in the command.
> 
> Finally, x86_64-pc-hdimg-gnome3 is a useful test for this case, but its
> broken, fix it.
> 
> 
> Torben Hohn (8):
>   elbeproject: cleanup licence file collection code
>   genlicence: switch to using ElbeProject
>   docs elbe-genlicence: document ElbeProject changes and also add --xml
>   efilesystem: add pkglist parameter to ElbeFilesystem.write_licenses()
>   elbeproject: remove unused "import sys"
>   pylint genlicence: remove unused import and styleproblem
>   pylint elbeproject: ignore too-many-arguments in gen_sdk_scripts() +
>     style
>   examples x86_64-pc-hdimg-gnome3: fix error in finetuning: add pkg
>     locales
> 
>  docs/elbe-genlicence.txt            | 20 ++++++++++----
>  elbepack/commands/genlicence.py     | 30 +++++++++++++++------
>  elbepack/efilesystem.py             | 16 ++++++-----
>  elbepack/elbeproject.py             | 42 +++++++++++++----------------
>  examples/x86_64-pc-hdimg-gnome3.xml |  1 +
>  5 files changed, 65 insertions(+), 44 deletions(-)
> 

For each contained patch:
Reviewed-by: Bastian Germann <bage at linutronix.de>



More information about the elbe-devel mailing list