[elbe-devel] [PATCH] finetuning: fix unimplemented action error

[Torben Hohn]

On Wed, Sep 04, 2019 at 11:03:55PM +0200, bage at linutronix.de wrote:
> From: Bastian Germann <bage at linutronix.de>
> 
> A KeyError might be thrown during action execution, which is the case
> for the updated example.
> 
> Signed-off-by: Bastian Germann <bage at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/finetuning.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/elbepack/finetuning.py b/elbepack/finetuning.py
> index 86a42c14..71875497 100644
> --- a/elbepack/finetuning.py
> +++ b/elbepack/finetuning.py
> @@ -706,10 +706,12 @@ def do_finetuning(xml, buildenv, target):
>      for i in xml.node('target/finetuning'):
>          try:
>              action = FinetuningAction(i)
> -            action.execute(buildenv, target)
>          except KeyError:
>              logging.exception("Unimplemented finetuning action '%s'",
>                                i.et.tag)
> +            return
> +        try:
> +            action.execute(buildenv, target)
>          except CommandError:
>              logging.exception("Finetuning Error, trying to continue anyways")
>          except FinetuningException:
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner