[elbe-devel] [PATCH 1/3] schema:Introduce <archive> element in schema

[Torben Hohn]

On Wed, Sep 04, 2019 at 04:03:18PM +0200, Akash Satamkar wrote:
> Handle the archive files and unpack the archive when
> the iso image is generated.
> 
> There can be more than one archive file which can be
> unpacked.
> 
> Signed-off-by: Akash Satamkar <akash at linutronix.de>

this patch only changes the schema.

"Handle the archive files and unpack the archive when the iso image
is generated." suggests, that this already contains the code to handle
this.

Please also mention, why the change from <all> to <sequence> is
necessary.

the actual diff is almost fine.

see inline...



> ---
>  schema/dbsfed.xsd | 45 +++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 43 insertions(+), 2 deletions(-)
> 
> diff --git a/schema/dbsfed.xsd b/schema/dbsfed.xsd
> index 14789d4e..8b26ebec 100644
> --- a/schema/dbsfed.xsd
> +++ b/schema/dbsfed.xsd
> @@ -2525,7 +2525,7 @@
>           Configuration of the src-cdrom
>        </documentation>
>      </annotation>
> -    <all>
> +    <sequence>
>        <element name="src-opts" type="rfs:iso-opts" minOccurs="0" maxOccurs="1">
>  	<annotation>
>            <documentation>
> @@ -2533,10 +2533,51 @@
>            </documentation>
>          </annotation>
>        </element>
> -    </all>
> +      <element name="archive" type="rfs:src-cdrom-archive" minOccurs="0" maxOccurs="unbounded">
> +        <annotation>
> +          <documentation>
> +                tar.bz2 file that contains additional files for the source
> +                cdrom.

mention that this is base64 encoded. 

> +          </documentation>
> +        </annotation>
> +      </element>
> +    </sequence>
>      <attribute ref="xml:base"/>
>    </complexType>
>  
> +     <complexType name="src-cdrom-archive">
> +       <annotation>
> +         <documentation>
> +           Holds a tar.bz2 file that is added to the src-cdrom.

Hold a base64 encoded tar.bz2 file that is added to src-cdroms.


> +         </documentation>
> +       </annotation>
> +       <simpleContent>
> +         <extension base="base64Binary">
> +           <attribute name="volume">
> +             <annotation>
> +               <documentation>
> +                 Use this to control where the archive is stored when using
> +                 split src-cdroms.
> +                 It consists of a comma-separated list of volume numbers.
> +                 A volume number can be 0 to n-1 for n equals the number
> +                 of volumes if the src-cdrom is split.
> +                 A volume number can also be negative to identify a volume
> +                 beginning from the last index.
> +                 (-1: last, -2: second last, ...)
> +                 If you do not specify this attribute, the archive is added
> +                 to each volume.
> +               </documentation>
> +             </annotation>
> +             <simpleType>
> +                 <restriction base="string">
> +                   <pattern value="(-?\d+,)*-?\d+"/>
> +                 </restriction>
> +             </simpleType>
> +           </attribute>
> +         </extension>
> +       </simpleContent>
> +     </complexType>
> +
>    <complexType name="iso-opts">
>      <annotation>
>        <documentation>
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner