[elbe-devel] [PATCH 1/3] treeutils:move check_boolean out of class etree

Torben Hohn torben.hohn at linutronix.de
Mon Sep 23 10:30:53 CEST 2019


On Mon, Sep 23, 2019 at 10:07:51AM +0200, Torben Hohn wrote:
> On Wed, Sep 18, 2019 at 12:11:52PM -0400, Olivier Dion wrote:
> > 
> > On 2019-09-18T09:34:10-0400, Bastian Germann <bage at linutronix.de> wrote:
> > 
> > > The callers of that method (in elbepack/archivedir.py) would have to be
> > > adapted to this change.
> > 
> > I recommend to keep check_boolean as a static method of the class etree
> > to avoid changing callers.
> 
> there are very few callers. And we want to get rid of this method.
> This method has nothing todo with our etree stuff, because it wants
> an Element as parameter. And so it should be moved away from
> treeutils.py at least.

errm.. there is only one caller, and that one is going to be removed in
the src-archive PQ.

So... this function should just go away.


> 
> 
> > 
> > --
> > Olivier Dion
> > Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
> > 
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> -- 
> Torben Hohn
> Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
> Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
> 
> Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
> can be found here): https://linutronix.de/kontakt/Datenschutz.php
> 
> Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
> Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
> 806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner



More information about the elbe-devel mailing list