[elbe-devel] [PATCH 06/12] esoap: return ELBE-FINISH only when the msg queue is empty

Torben Hohn torben.hohn at linutronix.de
Thu Sep 26 15:33:26 CEST 2019


it possible, that messages do not get logged, when the project switches
away from project_busy. Since the are likely to be the actual error
messages, we really want to print them, before we exit.

So ignore the ret value, until the logging queue is empty, and only then
check whether the project is still busy, and whether ELBE-FINISH should
be generated.

Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>
---
 elbepack/daemons/soap/esoap.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/elbepack/daemons/soap/esoap.py b/elbepack/daemons/soap/esoap.py
index aeb43e418..7b85584be 100644
--- a/elbepack/daemons/soap/esoap.py
+++ b/elbepack/daemons/soap/esoap.py
@@ -374,7 +374,7 @@ class ESoap (ServiceBase):
     def get_project_busy(self, uid, builddir):
         self.app.pm.open_project(uid, builddir)
         ret, msg = self.app.pm.current_project_is_busy(uid)
-        if not ret:
+        if not msg and not ret:
             return 'ELBE-FINISH'
         return msg
 
-- 
2.20.1




More information about the elbe-devel mailing list