[elbe-devel] [PATCH v3 4/6] xmlpreprocess: Add mirrors options preprocess rule

[Olivier Dion]

On Mon, 27 Jul 2020, Bastian Germann <bage at linutronix.de> wrote:
>> +                # And this is why goto are nice Guido van Rossum
>
> Duh! Please remove this comment. We do not want to bloat elbe with such
> stuff.

You're right.  I was a little grumpy that morning I guess :-) 

> Why don't you use a regex (with group) for this?

Sure I don't mind.  

> Do the options only work for binary urls? I guess at least a subset
> should also work for deb-src.

Hmm right.  Will do.

>
> There is a aptsources.sourceslist.SourceEntry.mysplit. Why don't you use
> this?

Did not know that was a thing.  

-- 
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen