[elbe-devel] [PATCH v2 1/6] commands: check-build: Create base for checkers

[Bastian Germann]

Am 04.08.20 um 17:49 schrieb Olivier Dion:
> On Tue, 04 Aug 2020, Bastian Germann <bage at linutronix.de> wrote:
>> Am 03.08.20 um 18:40 schrieb Olivier Dion:
>>> Checkers for a build should inherit from 'CheckBase' and register
>>> themself with 'CheckBase.register(tag)' where 'tag' is the name of the
>>> command on the command line.  As a special case, the command 'all'
>>> will run all checkers.  Checkers should implement the 'run' method to
>>> do their testing of the build.  The 'run' method should return 0 for
>>> success.
>>>
>>> Checkers can assume that their working directory is set to the build
>>> directory before entering 'run'.
>>>
>>> Any uncatch exception will result in a failure.  Calling
>>
>> Typo: uncatched
>>
>>> 'self.fail(reason)', returning none 0 from 'run' or setting 'self.ret'
>>> to none 0 will also result in a failure.
> 
>>
>> 2x: none or 0? or both?
> 
> none zero as in anything diffrent from 0.  I  guess that's confusing the
> way I put it.
> 

... a value not equal to 0 ...