[elbe-devel] [PATCH v2 2/6] commands: check-build: Add cdrom checker

[Torben Hohn]

On Tue, Aug 18, 2020 at 01:27:09PM -0400, Olivier Dion wrote:
> On Tue, 18 Aug 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:
> > On Tue, Aug 04, 2020 at 06:13:17PM +0200, Bastian Germann wrote:
> >> Am 04.08.20 um 18:07 schrieb Olivier Dion:
> >> > On Tue, 04 Aug 2020, Bastian Germann <bage at linutronix.de> wrote:
> >> >> Wow, that is a lot. Why don't you use python-apt's parser for all this
> >> >> stuff?
> >> > 
> >> > Correct me if I'm wrong.  But I don't think python-apt is required on
> >> > the host side. 
> >> 
> >> That is right but we can easily make it a host depdendency.
> >
> > no. we dont want to make python-apt a host dependency !
> > We spent several days getting rid of it on the host side.
> >
> >
> > It can be a dependency for the tests though.
> > Although that might mean, that the build checkers can not be used
> > by normal builds.
> 
> This remove the ability for users to check integrity of their builds
> after download.  We could run the check in the initvm, but this is going
> to be a lot slower with nested virtualization (check-build img|sdk) and
> won't check for download corruption.  The current scheme is working.  I
> have a WIP commit with Bastian recommendation of using python-apt if you
> change your mind.

no. i wont change my mind. Dont invest time in that.

> 
> I for one would like to avoid having to use python-apt on my host.  It
> was such a pain to install on Arch Linux, even with the AUR.  I can't
> imagine for other distros.

Fine with me. Especially since you seem to have done the heavylifting
already.


-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner