[elbe-devel] [PATCH v3 1/6] schema: dbfsed: Add mirror options

[Bastian Germann]

Am 23.07.20 um 18:31 schrieb Olivier Dion:
> The <options> tag can be used under <mirror> or <url>.  It accepts a
> sequence of <option> tag that are simple string to use as Apt options.

string -> strings

> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> ---
>  schema/dbsfed.xsd | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/schema/dbsfed.xsd b/schema/dbsfed.xsd
> index f1d1cae4..5a45a869 100644
> --- a/schema/dbsfed.xsd
> +++ b/schema/dbsfed.xsd
> @@ -205,6 +205,13 @@
>            </documentation>
>          </annotation>
>        </element>
> +      <element name="options" type="rfs:mirror-options" minOccurs="0" maxOccurs="1">
> +        <annotation>
> +          <documentation>
> +            List of options for this mirror
> +          </documentation>
> +        </annotation>
> +      </element>
>      </all>
>      <attribute ref="xml:base"/>
>    </complexType>
> @@ -234,6 +241,13 @@
>        </documentation>
>      </annotation>
>      <all>
> +      <element name="options" type="rfs:mirror-options" minOccurs="0" maxOccurs="1">
> +	<annotation>
> +          <documentation>
> +	    Options for the primary mirror.
> +          </documentation>
> +        </annotation>
> +      </element>
>        <element name="primary_host" type="rfs:string" minOccurs="0" maxOccurs="1">
>          <annotation>
>            <documentation>
> @@ -291,6 +305,24 @@
>      <attribute ref="xml:base"/>
>    </complexType>
>  
> +  <complexType name="mirror-options">
> +    <annotation>
> +      <documentation>
> +	List of options for a mirror
> +      </documentation>
> +    </annotation>
> +    <sequence>
> +      <element name="option" type="rfs:string" minOccurs="0" maxOccurs="unbounded">
> +        <annotation>
> +          <documentation>
> +	    e.g. trusted=yes or check-valid-until=no

There are several tabs in your indentation. Please replace them with spaces.

> +          </documentation>
> +        </annotation>
> +      </element>
> +    </sequence>
> +    <attribute ref="xml:base"/>
> +  </complexType>
> +
>    <complexType name="initvm">
>      <annotation>
>        <documentation>
> 

With the suggested changes:
Reviewed-by: Bastian Germann <bage at linutronix.de>