[elbe-devel] [PATCH 1/5] test: support ElbeTestCase.params being a callable

Bastian Germann bage at linutronix.de
Fri Jul 31 07:14:48 CEST 2020


Am 31.07.20 um 04:55 schrieb Olivier Dion:
> On Wed, 29 Jul 2020, Bastian Germann <bage at linutronix.de> wrote:
>> Am 23.07.20 um 04:51 schrieb Olivier Dion:
>>> Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>
>>> Reviewed-by: Olivier Dion <dion at linutronix.de>
>>
>> Who is the author? If it is Torben, please keep the From: line.
>> If it is Olivier, the S-o-b/R-b lines are bogus.
> 
> Torben is the author.  I gave my review if
> 
>>> -import copy
> 
> was added.  Since Torben went in vacation, I apply his patch and made
> the change myself.
> 
>> please keep the From: line.
> 
> To be clear.  You're refering to the 'From' field of the mail?
> 


If a From: line is in a git-format patch and git send-email has a
different sender, that line is kept as first line of the email payload.
The cover letter will also show the authors with their respective
patches in the overview.

Please change the author of that commit with git commit --amend --author


More information about the elbe-devel mailing list