[elbe-devel] [PATCH 40/75] repomanager: Fix Pylint

[Olivier Dion]

On Fri, 29 May 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:
> On Mon, May 25, 2020 at 11:42:33AM -0400, Olivier Dion wrote:
>> -    def removedeb(self, pkgname, component="main"):
>> +    def removedeb(self, pkgname, _component="main"):
>>          self._removedeb(pkgname, self.repo_attr.codename)
>
> i dont think that it makes sense to ignore the component.
> With your new changes, we might have different versions of some package
> in different components, and we probably dont want to remove the wrong
> ones.
> Maybe the code is not used currently, but this might lead to unexpected
> behaviour down the road.
> Please specify the component on the reprepro commandline.
> But first make sure about the default behaviour. What happens, when no
> component is specified ? Does it remove from all components ?
> Then we might want to have a default of component=None or something.

According to reprepro(1):
----------------------------------------------------------------------
-C, --component components

 Limit the specified command to this components only.  This will force
 added packages to this components, limit removing packages from this
 components, only list packages in this components, and/or otherwise
 only look at packages in this components, depending on the command in
 question.

 Multiple components are specified by separating them with |, as in
 -C 'main|contrib'.
----------------------------------------------------------------------

I think it's safe to assume that no component means all components.
I'll default to None and we can specify a list of components otherwise.

-- 
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen