[elbe-devel] [PATCH 57/75] dbaction: Fix Pylint

[Olivier Dion]

On Fri, 29 May 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:

>> @@ -269,6 +270,7 @@ class BuildAction(DbAction):
>>              ep = db.load_project(args[0])
>>              ep.build()
>>              db.update_project_files(ep)
>> +        # pylint: disable=broad-except
>
> this one is ok.
> But i would like to have this exception raised again.
> we must only cleanup in any case.
>
>
> why doesnt it complain about the BaseException above ?
> that one is wrong. 
>
> https://github.com/Linutronix/elbe/blob/dc9b6e81da58e9aa0968cad4b82d1727fe1d9062/elbepack/dbaction.py#L123

This is fixed by this commit
<https://github.com/PyCQA/pylint/commit/612b87a3b3eaa6e862198c99d120e492cbfa19d9>.
I use pylint 2.5.2 at home and this is still the case tho.

Anyway, I'm changing this for a ValueError.  Note that there's 32 of
occurences like that in Elbe.  Only 3 of those are printed.

-- 
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen