[elbe-devel] [PATCH v2 00/66] Elbe unittest - Pylint all Elbe

Olivier Dion dion at linutronix.de
Fri Jun 5 19:06:24 CEST 2020


* v1

  This patch set add pylint to Elbe' unittests.

  All commit for lint fixing are of the form:

  line-number:column-number: pylint-err-number: pylint-err-description

  This was done using pylint for Python3, thus many errors of
  inheritance with object were quiet down.  We could just add the
  'useless-object-inheritance' to the global disable list.

  Finally, last week I was able to test using 'pylint --jobs=0', thus
  having parallel checkers.  This week, parallel checkers generate
  duplicate errors, so I removed this option.

* v2

  Removes the debianize stuffs and better exception handling.

* Missing reviews

  [PATCH v2 03/66] .pylintrc: Add disabling option and pkg whitelist
  [PATCH v2 15/66] commands add: Fix Pylint
  [PATCH v2 19/66] daemons soap authentication: Fix Pylint
  [PATCH v2 21/66] daemons soap faults: Fix Pylint
  [PATCH v2 22/66] daemons soap __init__: Fix Pylint
  [PATCH v2 23/66] filesystem: Fix Pylint
  [PATCH v2 25/66] treeutils: Fix Pylint
  [PATCH v2 33/66] updated_monitors: Fix Pylint
  [PATCH v2 37/66] junit: Fix Pylint
  [PATCH v2 40/66] hdimg: Fix Pylint
  [PATCH v2 41/66] finetuning: Fix Pylint
  [PATCH v2 42/66] egpg: Fix Pylint
  [PATCH v2 43/66] shellhelper: Fix Pylint
  [PATCH v2 46/66] repomanager: Fix Pylint
  [PATCH v2 47/66] licencexml: Fix Pylint
  [PATCH v2 49/66] dbaction: Fix Pylint
  [PATCH v2 51/66] aptprogress: Fix Pylint
  [PATCH v2 64/66] elbe: Fix Pylint

Olivier Dion (66):
  tests test_pylint: Add pylint unittest
  Remove pylint too-few-public-methods
  .pylintrc:  Add disabling option and pkg whitelist
  commands bootup-check: Fix Pylint
  commands init: Fix Pylint
  commands sign: Fix Pylint
  commands updates: Fix Pylint
  commands adjustpkgs: Fix Pylint
  commands fetch_initvm_pkgs: Fix Pylint
  commands check_updates: Fix Pylint
  commands chroot: Fix Pylint
  commands toolchainextract: Fix Pylint
  commands hdimg: Fix Pylint
  commands control: Fix Pylint
  commands add: Fix Pylint
  commands prjrepo: Fix Pylint
  commands buildchroot: Fix Pylint
  commands daemon: Fix Pylint
  daemons soap authentication: Fix Pylint
  daemons soap esoap: Fix Pylint
  daemons soap faults: Fix Pylint
  daemons soap __init__: Fix Pylint
  filesystem: Fix Pylint
  efilesystem: Fix Pylint
  treeutils: Fix Pylint
  pkgarchive: Fix Pylint
  soapclient: Fix Pylint
  asyncworker: Fix Pylint
  toolchain: Fix Pylint
  cdroms: Fix Pylint
  fstab: Fix Pylint
  updated: Fix Pylint
  updated_monitors: Fix Pylint
  elbexml: Fix Pylint
  xmlpreprocess: Fix Pylint
  archivedir: Fix Pylint
  junit: Fix Pylint
  db: Fix Pylint
  projectmanager: Fix Pylint
  hdimg: Fix Pylint
  finetuning: Fix Pylint
  egpg: Fix Pylint
  shellhelper: Fix Pylint
  virtapt: Fix Pylint
  debinstaller: Fix Pylint
  repomanager: Fix Pylint
  licencexml: Fix Pylint
  log: Fix Pylint
  dbaction: Fix Pylint
  pbuilderaction: Fix Pylint
  aptprogress: Fix Pylint
  packers: Fix Pylint
  kvm: Fix Pylint
  elbeproject: Fix Pylint
  rfs: Fix Pylint
  changelogxml: Fix Pylint
  aptpkgutils: Fix Pylint
  hashes: Fix Pylint
  initvmaction: Fix Pylint
  rpcaptcache: Fix Pylint
  pbuilder: Fix Pylint
  templates: Fix Pylint
  updatepkg: Fix Pylint
  elbe: Fix Pylint
  xmldefaults: Fix Pylint
  asciidoclog: Remove from Elbe

 .pylintrc                               |   8 +-
 debian/python-elbe-buildenv.install     |   1 -
 debian/python3-elbe-buildenv.install    |   1 -
 elbe                                    |  11 +-
 elbepack/aptpkgutils.py                 |  22 ++--
 elbepack/aptprogress.py                 |  13 ++-
 elbepack/archivedir.py                  |   3 +-
 elbepack/asciidoclog.py                 |  55 ---------
 elbepack/asyncworker.py                 |  36 ++++--
 elbepack/cdroms.py                      |   3 +-
 elbepack/changelogxml.py                |   3 +-
 elbepack/commands/add.py                |  29 +++--
 elbepack/commands/adjustpkgs.py         |  85 +++++++-------
 elbepack/commands/bootup-check.py       |   2 +
 elbepack/commands/buildchroot.py        |   1 -
 elbepack/commands/check_updates.py      |   2 -
 elbepack/commands/chroot.py             |   2 +-
 elbepack/commands/control.py            |  14 +--
 elbepack/commands/daemon.py             |   1 +
 elbepack/commands/fetch_initvm_pkgs.py  |  10 ++
 elbepack/commands/hdimg.py              |   1 -
 elbepack/commands/init.py               |   2 +-
 elbepack/commands/prjrepo.py            |  14 +--
 elbepack/commands/sign.py               |   3 +-
 elbepack/commands/toolchainextract.py   |   2 +
 elbepack/commands/updated.py            |   2 +-
 elbepack/daemons/soap/__init__.py       |   7 +-
 elbepack/daemons/soap/authentication.py |  48 +++++---
 elbepack/daemons/soap/esoap.py          |   1 +
 elbepack/daemons/soap/faults.py         |  30 +++--
 elbepack/db.py                          |  27 ++---
 elbepack/dbaction.py                    |   8 +-
 elbepack/debinstaller.py                |   3 +-
 elbepack/efilesystem.py                 |  19 +--
 elbepack/egpg.py                        | 131 ++++++++++++---------
 elbepack/elbeproject.py                 |  23 ++--
 elbepack/elbexml.py                     |  11 +-
 elbepack/filesystem.py                  |  15 ++-
 elbepack/finetuning.py                  |   9 +-
 elbepack/fstab.py                       |  13 +--
 elbepack/hashes.py                      |   3 +-
 elbepack/hdimg.py                       |  29 +++--
 elbepack/initvmaction.py                |   5 +-
 elbepack/junit.py                       |  11 +-
 elbepack/kvm.py                         |   1 +
 elbepack/licencexml.py                  |  17 ++-
 elbepack/log.py                         |   6 +-
 elbepack/packers.py                     |  11 +-
 elbepack/pbuilder.py                    |   2 +
 elbepack/pbuilderaction.py              |   3 +-
 elbepack/pkgarchive.py                  |   1 +
 elbepack/pkgutils.py                    |   4 +-
 elbepack/projectmanager.py              |  15 +--
 elbepack/repomanager.py                 | 146 ++++++++++++++++--------
 elbepack/rfs.py                         |   3 +-
 elbepack/rpcaptcache.py                 |  13 ++-
 elbepack/shellhelper.py                 |  17 ++-
 elbepack/soapclient.py                  |  14 ++-
 elbepack/templates.py                   |   5 +-
 elbepack/tests/test_pylint.py           |  29 +++++
 elbepack/toolchain.py                   |   4 +-
 elbepack/treeutils.py                   |  26 ++---
 elbepack/updated.py                     |  30 ++---
 elbepack/updated_monitors.py            |  41 ++++---
 elbepack/updatepkg.py                   |   1 -
 elbepack/virtapt.py                     |  15 ++-
 elbepack/xmldefaults.py                 |   4 +-
 elbepack/xmlpreprocess.py               |   6 +-
 68 files changed, 664 insertions(+), 469 deletions(-)
 delete mode 100644 elbepack/asciidoclog.py
 create mode 100644 elbepack/tests/test_pylint.py

-- 
2.27.0




More information about the elbe-devel mailing list