[elbe-devel] [PATCH v2 41/66] finetuning: Fix Pylint

Torben Hohn torben.hohn at linutronix.de
Wed Jun 10 13:40:18 CEST 2020


On Fri, Jun 05, 2020 at 01:07:05PM -0400, Olivier Dion wrote:
> 35:0:  R0205: (useless-object-inheritance)
> 73:65: E1101: (no-member)
> 681:0: W0223: (abstract-method)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/finetuning.py | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/elbepack/finetuning.py b/elbepack/finetuning.py
> index 71875497..cfcb5af1 100644
> --- a/elbepack/finetuning.py
> +++ b/elbepack/finetuning.py
> @@ -31,11 +31,14 @@ from elbepack.shellhelper import chroot, do, get_command_out
>  class FinetuningException(Exception):
>      pass
>  
> -
> +# TODO:py3 Remove object inheritance
> +# pylint: disable=useless-object-inheritance
>  class FinetuningAction(object):
>  
>      actiondict = {}
>  
> +    tag = None
> +
>      @classmethod
>      def register(cls, tag, register=True):
>          def _register(action):
> @@ -682,6 +685,10 @@ class TestSuites(FinetuningAction):
>  
>      elbe_junit = "elbe-junit.xml"
>  
> +    def execute(self, _buildenv, _target):
> +        raise NotImplementedError("<%s> can only be used in the context of a project" %
> +                                  self.tag)
> +
>      def execute_prj(self, buildenv, target, builddir):
>  
>          tss = []
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner



More information about the elbe-devel mailing list