[elbe-devel] [PATCH] rpcaptcache: Fix bad exception

[Bastian Germann]

Am 26.06.20 um 16:38 schrieb Olivier Dion:
> ----------------------------------------------------------------------
> [ERROR] Build failed
> Traceback (most recent call last):
>   File "/var/cache/elbe/devel/elbepack/asyncworker.py", line 194, in execute
>     skip_pbuild=self.skip_pbuilder)
>   File "/var/cache/elbe/devel/elbepack/elbeproject.py", line 686, in build
>     self.build_cdroms(build_bin, build_sources, cdrom_size,
> tgt_pkg_lst=tgt_pkgs)
>   File "/var/cache/elbe/devel/elbepack/elbeproject.py", line 547, in
> build_cdroms
>     **kwargs)
>   File "/var/cache/elbe/devel/elbepack/cdroms.py", line 74, in
> mk_source_cdrom
>     forbiddenPackages)
>   File "/var/cache/elbe/devel/elbepack/cdroms.py", line 36, in
> add_source_pkg
>     '/var/cache/elbe/sources')
>   File "<string>", line 2, in download_source
>   File "/usr/lib/python2.7/multiprocessing/managers.py", line 774, in
> _callmethod
>     raise convert_to_error(kind, result)
> TypeError: exceptions must be old-style classes or derived from
> BaseException, not str
> Project build was not successful, current status: build_failed
> elbe control wait_busy Failed
> ----------------------------------------------------------------------
> 
> Reported-by: Bastian Germann <bage at linutronix.de>
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Bastian Germann <bage at linutronix.de>
Tested-by: Bastian Germann <bage at linutronix.de>

> ---
>  elbepack/rpcaptcache.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/elbepack/rpcaptcache.py b/elbepack/rpcaptcache.py
> index 902ea54f..b02f2f04 100644
> --- a/elbepack/rpcaptcache.py
> +++ b/elbepack/rpcaptcache.py
> @@ -351,7 +351,7 @@ class RPCAPTCache(InChRootObject):
>              next_p = rec.lookup(src_name)
>              # End of the list?
>              if not next_p:
> -                raise ("No source found for %s_%s" % (src_name, src_version))
> +                raise ValueError("No source found for %s_%s" % (src_name, src_version))
>              if src_version == rec.version:
>                  break
>  
>