[elbe-devel] [PATCH 4/4] Change log level for error in write license of RFS

[Torben Hohn]

On Thu, Mar 05, 2020 at 12:23:39AM -0500, Olivier Dion wrote:
> This is useful for the target RFS since '/usr/share/doc/' might not
> exists.  Thus changing log level from exception to warning to prevent
> the build from failing.

files in the target RFS are copied from chroot.
You have to collect the files for the target RFS from there.

thats special.

Also make sure, that the sysroots also contain /usr/share/doc
or you look in the right place, where that is not stripped yet.

Also... if a licence file does not exist, its at least an Error.
The result can not be used in production.
People overlook warnings in the huge elbe logs.
Thats not an option here. 

> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> ---
>  elbepack/efilesystem.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/efilesystem.py b/elbepack/efilesystem.py
> index 5bc20afd..395947b6 100644
> --- a/elbepack/efilesystem.py
> +++ b/elbepack/efilesystem.py
> @@ -150,8 +150,8 @@ class ElbeFilesystem(Filesystem):
>                  with io.open(copyright_fname, "rb") as lic:
>                      lic_text = lic.read()
>              except IOError as e:
> -                logging.exception("Error while processing license file %s",
> -                                  copyright_fname)
> +                logging.warning("Error while processing license file %s",
> +                                copyright_fname)
>                  lic_text = "Error while processing license file %s: '%s'" % (
>                      copyright_file, e.strerror)
>  
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner