[elbe-devel] [PATCH v2 4/4] elbeproject: Pass other components to mk_source_cdrom

[Torben Hohn]

On Sun, May 10, 2020 at 06:22:10PM -0400, Olivier Dion wrote:
> On Sat, 09 May 2020, Olivier Dion <dion at linutronix.de> wrote:
> > On Fri, 08 May 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:
> >
> >>>                  try:
> >>>                      self.repo_images += mk_source_cdrom(env.rfs,
> >>>                                                          self.arch,
> >>> @@ -486,7 +519,8 @@ class ElbeProject (object):
> >>>                                                          init_codename,
> >>>                                                          self.builddir,
> >>>                                                          cdrom_size=cdrom_size,
> >>> -                                                        xml=self.xml)
> >>> +                                                        xml=self.xml,
> >>> +                                                        others=others)
> >>
> >> now you have others here. 
> >> I dont really see them very different from env.rfs 
> >>
> >> Please try to generalize this, so that the others and env.rfs could be
> >> part of the same dict/list
> >>
> >> Maybe pass in a list of BuildEnv or something ?
> >
> > Alright, let's pass a dictionnary of the form { "component": dsc_lst }.
> > Packages will be downloaded before the call to mk_source_cdrom using the
> > correct BuildEnv.
> >
> > However, this requires to pass the mirror explicitly.
> 
> After though, this is a bad idea since it would requires to move the
> forbiden packages filtering outside of mk_source_cdrom too.
> 
> My current solution passes a dictionnary of the form -
> [ component-name : (rfs, cache, pkg_lst)].

yeah. but you also pass the first parameter.

that parameter is treated specially, while it could just be
part of the dictionary.


> 
> -- 
> Olivier Dion
> Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner