[elbe-devel] [PATCH 3/5] cdroms: Change call to download_source

[Torben Hohn]

On Tue, May 19, 2020 at 10:27:01PM -0400, Olivier Dion wrote:
> Since there's no default version for the source package in the call of
> download_source, the parameter version and dest_dir were reversed.
> 
> Also, added a logging for component just to keep track which packages
> are from whom.
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/cdroms.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/elbepack/cdroms.py b/elbepack/cdroms.py
> index 72d0fba6..a09e0525 100644
> --- a/elbepack/cdroms.py
> +++ b/elbepack/cdroms.py
> @@ -30,9 +30,7 @@ def add_source_pkg(repo, component, cache, pkg, version, forbid):
>          return
>      pkg_id = "%s-%s" % (pkg, version)
>      try:
> -        dsc = cache.download_source(pkg,
> -                                    '/var/cache/elbe/sources',
> -                                    version=version)
> +        dsc = cache.download_source(pkg, version, '/var/cache/elbe/sources')
>          repo.includedsc(dsc, component=component, force=True)
>      except ValueError:
>          logging.error("No sources for package '%s'", pkg_id)
> @@ -65,6 +63,7 @@ def mk_source_cdrom(components, codename,
>                  pass
>  
>      for component, (rfs, cache, pkg_lst) in components.items():
> +        logging.info("Adding %s component", component)
>          rfs.mkdir_p('/var/cache/elbe/sources')
>          for pkg, version in pkg_lst:
>              add_source_pkg(repo, component,
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner