[elbe-devel] [PATCH 5/5] commands mkcdrom: Generate source list for building source cdrom

[Torben Hohn]

On Mon, May 25, 2020 at 08:55:08AM -0400, Olivier Dion wrote:
> On Mon, 25 May 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:
> > On Tue, May 19, 2020 at 10:27:03PM -0400, Olivier Dion wrote:
> >> mk_source_cdrom() is now expecting a list of tuples of the
> >> form (src_name, src_version) instead of (bin_name, bin_version).
> >> 
> >> Signed-off-by: Olivier Dion <dion at linutronix.de>
> >> ---
> >>  elbepack/commands/mkcdrom.py | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/elbepack/commands/mkcdrom.py b/elbepack/commands/mkcdrom.py
> >> index 82551a1c..ca1e5ba9 100644
> >> --- a/elbepack/commands/mkcdrom.py
> >> +++ b/elbepack/commands/mkcdrom.py
> >> @@ -94,7 +94,9 @@ def run_command(argv):
> >>                  cache = get_rpcaptcache(rfs, arch)
> >>                  pkg_lst = [(pkg.name, pkg.installed_version)
> >>                             for pkg in cache.get_installed_pkgs()]
> >
> > isnt pkg_lst unused now ?
> > The linter should complain...
> 
> True.  Will remove.

ok... then...
Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> 
> -- 
> Olivier Dion
> Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner