[elbe-devel] [PATCH 00/75] Elbe unittest - Pylint all Elbe

[Olivier Dion]

This patch set add pylint to Elbe' unittests.

All commit for lint fixing are of the form:

line-number:column-number: pylint-err-number: pylint-err-description


This was done using pylint for Python3, thus many errors of
inheritance with object were quiet down.  We could just add the
'useless-object-inheritance' to the global disable list.

Finally, last week I was able to test using 'pylint --jobs=0', thus
having parallel checkers.  This week, parallel checkers generate
duplicate errors, so I removed this option.

Olivier Dion (75):
  tests test_pylint: Add pylint unittest
  Remove pylint too-few-public-methods
  .pylintrc:  Add disabling option and pkg whitelist
  commands bootup-check: Fix Pylint
  commands init: Fix Pylint
  commands sign: Fix Pylint
  commands updates: Fix Pylint
  commands adjustpkgs: Fix Pylint
  commands fetch_initvm_pkgs: Fix Pylint
  commands check_updates: Fix Pylint
  commands chroot: Fix Pylint
  commands toolchainextract: Fix Pylint
  commands hdimg: Fix Pylint
  commands control: Fix Pylint
  commands add: Fix Pylint
  commands prjrepo: Fix Pylint
  commands buildchroot: Fix Pylint
  commands daemon: Fix Pylint
  debianize base tui: Fix Pylint
  debianize panels base: Fix Pylint
  debianize panels kernel: Fix Pylint
  debianize widgets button: Fix Pylint
  debianize widgets grid: Fix Pylint
  debianize widgets radio: Fix Pylint
  daemons soap esoap: Fix Pylint
  debianize widgets form: Fix Pylint
  daemons soap __init__: Fix Pylint
  daemons soap faults: Fix Pylint
  filesystem: Fix Pylint
  efilesystem: Fix Pylint
  treeutils: Fix Pylint
  pkgarchive: Fix Pylint
  soapclient: Fix Pylint
  asyncworker: Fix Pylint
  toolchain: Fix Pylint
  validate: Fix Pylint
  cdroms: Fix Pylint
  fstab: Fix Pylint
  updated: Fix Pylint
  repomanager: Fix Pylint
  updated_monitors: Fix Pylint
  elbexml: Fix Pylint
  xmlpreprocess: Fix Pylint
  archivedir: Fix Pylint
  junit: Fix Pylint
  daemons soap authentication: Fix Pylint
  db: Fix Pylint
  projectmanager: Fix Pylint
  hdimg: Fix Pylint
  finetuning: Fix Pylint
  egpg: Fix Pylint
  shellhelper: Fix Pylint
  virtapt: Fix Pylint
  licencexml: Fix Pylint
  debinstaller: Fix Pylint
  log: Fix Pylint
  dbaction: Fix Pylint
  pbuilderaction: Fix Pylint
  aptprogress: Fix Pylint
  packers: Fix Pylint
  kvm: Fix Pylint
  elbeproject: Fix Pylint
  rfs: Fix Pylint
  changelogxml: Fix Pylint
  aptpkgutils: Fix Pylint
  hashes: Fix Pylint
  initvmaction: Fix Pylint
  rpcaptcache: Fix Pylint
  pbuilder: Fix Pylint
  debpkg: Fix Pylint
  templates: Fix Pylint
  updatepkg: Fix Pylint
  elbe: Fix Pylint
  xmldefaults: Fix Pylint
  asciidoclog: Remove from Elbe

 .pylintrc                               |  5 +-
 debian/python-elbe-buildenv.install     |  1 -
 debian/python3-elbe-buildenv.install    |  1 -
 elbe                                    |  4 +-
 elbepack/aptpkgutils.py                 | 22 ++++---
 elbepack/aptprogress.py                 |  7 +-
 elbepack/archivedir.py                  |  3 +-
 elbepack/asciidoclog.py                 | 55 ----------------
 elbepack/asyncworker.py                 | 36 +++++++++--
 elbepack/cdroms.py                      |  1 +
 elbepack/changelogxml.py                |  3 +-
 elbepack/commands/add.py                |  3 +
 elbepack/commands/adjustpkgs.py         | 85 ++++++++++++-------------
 elbepack/commands/bootup-check.py       |  2 +
 elbepack/commands/buildchroot.py        |  1 -
 elbepack/commands/check_updates.py      |  2 -
 elbepack/commands/chroot.py             |  2 +-
 elbepack/commands/control.py            | 14 ++--
 elbepack/commands/daemon.py             |  1 +
 elbepack/commands/fetch_initvm_pkgs.py  |  3 +
 elbepack/commands/hdimg.py              |  1 -
 elbepack/commands/init.py               |  2 +-
 elbepack/commands/prjrepo.py            | 14 ++--
 elbepack/commands/sign.py               |  3 +-
 elbepack/commands/toolchainextract.py   |  2 +
 elbepack/commands/updated.py            |  2 +-
 elbepack/daemons/soap/__init__.py       |  1 +
 elbepack/daemons/soap/authentication.py |  2 +
 elbepack/daemons/soap/esoap.py          |  1 +
 elbepack/daemons/soap/faults.py         |  3 +
 elbepack/db.py                          | 27 ++++----
 elbepack/dbaction.py                    |  4 +-
 elbepack/debianize/base/tui.py          | 11 ++--
 elbepack/debianize/panels/base.py       | 21 +++---
 elbepack/debianize/panels/kernel.py     |  3 +-
 elbepack/debianize/widgets/button.py    |  5 +-
 elbepack/debianize/widgets/form.py      |  8 ++-
 elbepack/debianize/widgets/grid.py      |  8 +--
 elbepack/debianize/widgets/radio.py     |  4 +-
 elbepack/debinstaller.py                |  3 +-
 elbepack/debpkg.py                      |  1 +
 elbepack/efilesystem.py                 | 19 ++++--
 elbepack/egpg.py                        | 65 ++++++++++++-------
 elbepack/elbeproject.py                 | 14 +++-
 elbepack/elbexml.py                     | 11 +++-
 elbepack/filesystem.py                  | 18 +++---
 elbepack/finetuning.py                  |  8 ++-
 elbepack/fstab.py                       | 13 +---
 elbepack/hashes.py                      |  3 +-
 elbepack/hdimg.py                       | 24 +++++--
 elbepack/initvmaction.py                |  5 +-
 elbepack/junit.py                       | 13 ++--
 elbepack/kvm.py                         |  1 +
 elbepack/licencexml.py                  |  5 +-
 elbepack/log.py                         |  6 +-
 elbepack/packers.py                     | 11 ++--
 elbepack/pbuilder.py                    |  2 +
 elbepack/pbuilderaction.py              |  3 +-
 elbepack/pkgarchive.py                  |  1 +
 elbepack/pkgutils.py                    |  4 +-
 elbepack/projectmanager.py              | 15 +++--
 elbepack/repomanager.py                 | 15 +++--
 elbepack/rfs.py                         |  3 +-
 elbepack/rpcaptcache.py                 | 13 ++--
 elbepack/shellhelper.py                 |  9 ++-
 elbepack/soapclient.py                  | 14 ++--
 elbepack/templates.py                   |  5 +-
 elbepack/tests/test_pylint.py           | 28 ++++++++
 elbepack/toolchain.py                   |  5 +-
 elbepack/treeutils.py                   | 28 ++++----
 elbepack/updated.py                     | 30 +++++----
 elbepack/updated_monitors.py            |  9 ++-
 elbepack/updatepkg.py                   |  1 -
 elbepack/validate.py                    |  2 +
 elbepack/virtapt.py                     | 16 +++--
 elbepack/xmldefaults.py                 |  4 +-
 elbepack/xmlpreprocess.py               |  6 +-
 77 files changed, 467 insertions(+), 339 deletions(-)
 delete mode 100644 elbepack/asciidoclog.py
 create mode 100644 elbepack/tests/test_pylint.py

-- 
2.26.2