[elbe-devel] [PATCH 43/75] xmlpreprocess: Fix Pylint

[Torben Hohn]

On Mon, May 25, 2020 at 11:42:36AM -0400, Olivier Dion wrote:
> 232:0: R0205: (useless-object-inheritance)
> 262:8: C0415: (import-outside-toplevel)
> 262:8: R0401: (cyclic-import)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/xmlpreprocess.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/elbepack/xmlpreprocess.py b/elbepack/xmlpreprocess.py
> index d0714489..de19a644 100644
> --- a/elbepack/xmlpreprocess.py
> +++ b/elbepack/xmlpreprocess.py
> @@ -229,7 +229,9 @@ def xmlpreprocess(fname, output, variants=None):
>      raise XMLPreprocessError("\n".join(error_log_to_strings(schema.error_log)))
>  
>  
> -class PreprocessWrapper(object):    # pylint: disable=too-few-public-methods
> +# TODO:py3 Remove object inheritance
> +# pylint: disable=useless-object-inheritance
> +class PreprocessWrapper(object):
>      def __init__(self, xmlfile, opt):
>          self.xmlfile = xmlfile
>          self.outxml = None
> @@ -259,6 +261,8 @@ class PreprocessWrapper(object):    # pylint: disable=too-few-public-methods
>      @staticmethod
>      def add_options(oparser):
>          # import it here because of cyclic imports
> +        # pylint: disable=import-outside-toplevel
> +        # pylint: disable=cyclic-import
>          from elbepack.commands.preprocess import add_pass_through_options
>  
>          group = OptionGroup(oparser,
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner