[elbe-devel] [PATCH 50/75] finetuning: Fix Pylint

[Torben Hohn]

On Mon, May 25, 2020 at 11:42:43AM -0400, Olivier Dion wrote:
> 35:0:  R0205: (useless-object-inheritance)
> 73:65: E1101: (no-member)
> 681:0: W0223: (abstract-method)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> ---
>  elbepack/finetuning.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/elbepack/finetuning.py b/elbepack/finetuning.py
> index 71875497..5732ed97 100644
> --- a/elbepack/finetuning.py
> +++ b/elbepack/finetuning.py
> @@ -31,7 +31,8 @@ from elbepack.shellhelper import chroot, do, get_command_out
>  class FinetuningException(Exception):
>      pass
>  
> -
> +# TODO:py3 Remove object inheritance
> +# pylint: disable=useless-object-inheritance
>  class FinetuningAction(object):
>  
>      actiondict = {}
> @@ -69,6 +70,8 @@ class ImageFinetuningAction(FinetuningAction):
>          FinetuningAction.__init__(self, node)
>  
>      def execute(self, _buildenv, _target):
> +        # self.tag is defined in registration

lets have self.tag = None in base constructor.

> +        # pylint: disable=no-member
>          raise NotImplementedError("<%s> may only be "
>                                    "used in <image-finetuning>" % self.tag)
>  
> @@ -680,6 +683,9 @@ class CopyToPartition(ImageFinetuningAction):
>  @FinetuningAction.register("unit-tests")
>  class TestSuites(FinetuningAction):
>  
> +    # excute() is not implemented because this is a project action
> +    # pylint: disable=abstract-method

mmm... bu we have execute in the Baseclass.
why does it complain ?

thats weird
anyways... the others also just raise NotImplementedError in execute,
please do that there also.


> +
>      elbe_junit = "elbe-junit.xml"
>  
>      def execute_prj(self, buildenv, target, builddir):
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner