[elbe-devel] [PATCH 54/75] licencexml: Fix Pylint

[Torben Hohn]

On Mon, May 25, 2020 at 11:42:47AM -0400, Olivier Dion wrote:
> 46:0:   R0205: (useless-object-inheritance)
> 101:15: W0703: (broad-except)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> ---
>  elbepack/licencexml.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/elbepack/licencexml.py b/elbepack/licencexml.py
> index f5f4ee5e..d1b21a41 100644
> --- a/elbepack/licencexml.py
> +++ b/elbepack/licencexml.py
> @@ -42,7 +42,8 @@ def get_heuristics_license_list(c):
>  
>      return set(licenses)
>  
> -
> +# TODO:py3 Remove object inheritance
> +# pylint: disable=useless-object-inheritance
>  class copyright_xml (object):
>      def __init__(self):
>          self.outxml = etree(None)
> @@ -98,6 +99,8 @@ class copyright_xml (object):
>  
>              return
>  
> +        # TODO - Handle me?
> +        # pylint: disable=broad-except

yeah. we really want this handled.
IIRC we had a set of problems with broken encodings.
But this one really hides typos.

just ignoring exceptions without printing them is almost
always a fatal error.

>          except Exception:
>              pass
>  
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner