[elbe-devel] [PATCH 57/75] dbaction: Fix Pylint

[Torben Hohn]

On Mon, May 25, 2020 at 11:42:50AM -0400, Olivier Dion wrote:
> 18:0:   R0205: (useless-object-inheritance)
> 272:15: W0703: (broad-except)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> ---
>  elbepack/dbaction.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/elbepack/dbaction.py b/elbepack/dbaction.py
> index 7cd66314..0c1d8a33 100644
> --- a/elbepack/dbaction.py
> +++ b/elbepack/dbaction.py
> @@ -14,7 +14,8 @@ from getpass import getpass
>  from shutil import copyfileobj
>  from elbepack.db import ElbeDB, ElbeDBError
>  
> -
> +# TODO:py3 Remove object inheritance
> +# pylint: disable=useless-object-inheritance
>  class DbAction(object):
>  
>      actiondict = {}
> @@ -269,6 +270,7 @@ class BuildAction(DbAction):
>              ep = db.load_project(args[0])
>              ep.build()
>              db.update_project_files(ep)
> +        # pylint: disable=broad-except

this one is ok.
But i would like to have this exception raised again.
we must only cleanup in any case.


why doesnt it complain about the BaseException above ?
that one is wrong. 

https://github.com/Linutronix/elbe/blob/dc9b6e81da58e9aa0968cad4b82d1727fe1d9062/elbepack/dbaction.py#L123

>          except Exception as e:
>              db.update_project_files(ep)
>              db.reset_busy(args[0], "build_failed")
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner