[elbe-devel] [PATCH 67/75] initvmaction: Fix Pylint

[Torben Hohn]

On Mon, May 25, 2020 at 11:43:00AM -0400, Olivier Dion wrote:
> 51:0:   R0205: (useless-object-inheritance)
> 629:16: W0612: (unused-variable)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>


hmmm... not sure, if we dont want to allow --skip-urlcheck
at some point. 

But lets remove it for now...

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/initvmaction.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/elbepack/initvmaction.py b/elbepack/initvmaction.py
> index f8572402..7c60cc37 100644
> --- a/elbepack/initvmaction.py
> +++ b/elbepack/initvmaction.py
> @@ -47,7 +47,8 @@ class InitVMError(Exception):
>      def __init__(self, msg):
>          Exception.__init__(self, msg)
>  
> -
> +# TODO:py3 Remove object inheritance
> +# pylint: disable=useless-object-inheritance
>  class InitVMAction(object):
>      actiondict = {}
>  
> @@ -626,13 +627,11 @@ class SubmitAction(InitVMAction):
>              if args[0].endswith('.xml'):
>                  # We have an xml file, use that for elbe init
>                  xmlfile = args[0]
> -                url_validation = ''
>              elif args[0].endswith('.iso'):
>                  # We have an iso image, extract xml from there.
>                  tmp = extract_cdrom(args[0])
>  
>                  xmlfile = tmp.fname('source.xml')
> -                url_validation = '--skip-urlcheck'
>                  cdrom = args[0]
>              else:
>                  print(
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner