[elbe-devel] Management of mirror, duplication of code?

[Torben Hohn]

On Tue, Sep 08, 2020 at 10:08:44AM +0200, Köry Maincent wrote:
> Hello,
> 
> I have noticed these two functions are pretty much the same:
>  create_apt_sources_list
>  get_apt_mirrors_and_keys
> 
> The second one should be corrected to manage the mirror like the first
> one. I would made a fix however I am wondering if it may be better to
> not duplicate the code?
> 
> Is there a reason to have two functions separated here?

No real reason.
The second function also does key extraction.

get_apt_mirrors_and_keys() needs to be changed to get_apt_keys()
and then xml.create_apt_sources_list() could be used.

However, it either needs an additional parameter to add

local_http = "deb http://127.0.0.1:8080%s/repo %s main" % (builddir, suite)

to the list.

but this could also be moved to:

pbuilder_write_repo_hook()

> 
> Regards,
> 
> -- 
> Köry Maincent, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner