[elbe-devel] [EXTERNAL MAIL]Re: [PATCH] Dockerfile.in: avoid blocking if user is AD user

[Buehler, Matthias]

Hi Bastian,

here my patch with singed-off:

From 1b0fef6d311eff83fa80a8c8cbe46c4c4ec5801f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20B=C3=BChler?= <matthias.buehler at trumpf.com>
Date: Tue, 3 Dec 2019 09:52:16 +0100
Subject: [PATCH] Dockerfile.in: added parameter -l to useradd to avoid
 blocking if user is AD user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Matthias Bühler <matthias.buehler at trumpf.com>
---
 contrib/dockerfile/Dockerfile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/dockerfile/Dockerfile.in b/contrib/dockerfile/Dockerfile.in
index cf1d5687..d93095db 100644
--- a/contrib/dockerfile/Dockerfile.in
+++ b/contrib/dockerfile/Dockerfile.in
@@ -62,7 +62,7 @@ RUN rm -rf /var/lib/apt/lists/*
 
 # create elbe user
 RUN groupadd -g @KVMGID@ -o -r kvm-elbe
-RUN useradd -d /home/elbe -U -G kvm-elbe,libvirt -m -s /bin/bash -u @USERID@ elbe
+RUN useradd -d /home/elbe -l -U -G kvm-elbe,libvirt -m -s /bin/bash -u @USERID@ elbe
 RUN echo "root:elbe" | chpasswd
 RUN echo "elbe:elbe" | chpasswd
 
-- 
2.11.0

Regards
Matthias

-----Ursprüngliche Nachricht-----
Von: Bastian Germann <bage at linutronix.de> 
Gesendet: Mittwoch, 13. Januar 2021 14:20
An: Buehler, Matthias <Matthias.Buehler at trumpf.com>; elbe-devel at linutronix.de
Betreff: [EXTERNAL MAIL]Re: [elbe-devel] [PATCH] Dockerfile.in: avoid blocking if user is AD user

Am 06.11.20 um 09:15 schrieb Buehler, Matthias:
> When trying to build docker image with an AD-user docker build blocks in call to useradd. Searching the internet showed it is a known problem with useradd in docker. As a workaround one can add option -l. Applying that to elbe solved my problem.
> 
>  From 1b0fef6d311eff83fa80a8c8cbe46c4c4ec5801f Mon Sep 17 00:00:00 
> 2001
> From: =?UTF-8?q?Matthias=20B=C3=BChler?= <matthias.buehler at trumpf.com>
> Date: Tue, 3 Dec 2019 09:52:16 +0100
> Subject: [PATCH] Dockerfile.in: added parameter -l to useradd to avoid
>   blocking if user is AD user

Hi Matthias,

Please resend your `git format-patch` formatted patch with a Signed-off-by line that certifies the origin of the patch. With this you say that for this elbe contribution you agree to https://developercertificate.org/

Sorry for the late answer.

Regards,
Bastian

> ---
>   contrib/dockerfile/Dockerfile.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/dockerfile/Dockerfile.in 
> b/contrib/dockerfile/Dockerfile.in
> index cf1d56873..d93095db6 100644
> --- a/contrib/dockerfile/Dockerfile.in
> +++ b/contrib/dockerfile/Dockerfile.in
> @@ -62,7 +62,7 @@ RUN rm -rf /var/lib/apt/lists/*
> 
>   # create elbe user
>   RUN groupadd -g @KVMGID@ -o -r kvm-elbe -RUN useradd -d /home/elbe 
> -U -G kvm-elbe,libvirt -m -s /bin/bash -u @USERID@ elbe
> +RUN useradd -d /home/elbe -l -U -G kvm-elbe,libvirt -m -s /bin/bash 
> +-u @USERID@ elbe
>   RUN echo "root:elbe" | chpasswd
>   RUN echo "elbe:elbe" | chpasswd
> 
> --
> 2.11.0
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel
>