[elbe-devel] [PATCH v2 6/7] tests test_xml: improve the subTest message

Bastian Germann bage at linutronix.de
Fri Jan 15 12:38:11 CET 2021


Am 14.01.21 um 18:07 schrieb Torben Hohn:
> It not clear that "(cmd=rebuild)" means that "elbe check-build rebuild"
> is run.
> 
> Improve the subTest message.
> 
> Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>

Reviewed-by: Bastian Germann <bage at linutronix.de>

> ---
>   elbepack/tests/test_xml.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/elbepack/tests/test_xml.py b/elbepack/tests/test_xml.py
> index 30d57dc71..c4124f1a9 100644
> --- a/elbepack/tests/test_xml.py
> +++ b/elbepack/tests/test_xml.py
> @@ -40,7 +40,7 @@ class TestSimpleXML(ElbeTestCase):
>                              (elbe_exe, uuid))
>   
>                   for cmd in ("cdrom", "img", "sdk", "rebuild"):
> -                    with self.subTest(cmd=cmd):
> +                    with self.subTest(f'check build {cmd}'):
>                           system('%s check-build %s "%s"' % (elbe_exe, cmd, build_dir))
>   
>               # pylint: disable=try-except-raise
> 


More information about the elbe-devel mailing list