[elbe-devel] [PATCH v2 00/12] Fix Pylint

Torben Hohn torben.hohn at linutronix.de
Thu Jul 22 17:10:00 CEST 2021


Fix some Pylint errors and warnings.

After merging v1, "elbe test" did not work properly anymore,
because during elbe test the constructors are called with
parameters.

Please use "elbe test" before submitting a patch.
Especially if you directly touch "elbe test" code :)

Changes for v2:

- removed the def __init__() from the test_* patches.
  moved the definitiion of self.stdout to the baseclass.
  make the code actually evaluate it. 
  (It was ignored before)

- reorder the setting becasuse self.skipTest() actually
  throws an Exception

Christian Teklenborg (10):
  efilesystem: Fix Pylint
  finetuning: Fix Pylint
  pbuilder: Fix Pylint
  shellhelper: Fix Pylint
  soapclient: Fix Pylint
  test_preproc: Fix Pylint
  updated: Fix Pylint
  updated_monitors: Fix Pylint
  test_pylint: Fix Pylint
  Add python3-parted as dependency

Torben Hohn (2):
  test: add stdout field to ElbeTestCase and evaluate it in addSkip()
  tests: set self.stdout before self.skipTest() is called

 debian/control                 |   1 +
 elbepack/commands/test.py      |   3 +
 elbepack/efilesystem.py        |   2 +
 elbepack/finetuning.py         |  10 +--
 elbepack/pbuilder.py           |  24 +++----
 elbepack/shellhelper.py        |   8 +--
 elbepack/soapclient.py         |   3 +-
 elbepack/tests/test_preproc.py |   5 +-
 elbepack/tests/test_pylint.py  |   4 +-
 elbepack/updated.py            |   2 +-
 elbepack/updated_monitors.py   | 110 +++++++++++++++------------------
 11 files changed, 82 insertions(+), 90 deletions(-)

-- 
2.20.1



More information about the elbe-devel mailing list