[elbe-devel] [PATCH 10/16] db: fix pylint

Bastian Germann bage at linutronix.de
Wed Jul 28 19:27:20 CEST 2021


Am 28.07.21 um 17:40 schrieb Torben Hohn:
> elbepack/db.py:24:0: C0411: third party import "from sqlalchemy.ext.declarative import declarative_base" should be placed before "from p
> asslib.hash import pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:25:0: C0411: third party import "from sqlalchemy import Column, ForeignKey" should be placed before "from passlib.hash im
> port pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:26:0: C0411: third party import "from sqlalchemy import Integer, String, Boolean, Sequence, DateTime" should be placed before
> "from passlib.hash import pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:28:0: C0411: third party import "from sqlalchemy import create_engine" should be placed before "from passlib.hash import
> pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:29:0: C0411: third party import "from sqlalchemy.orm import sessionmaker, scoped_session" should be placed before "from p
> asslib.hash import pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:30:0: C0411: third party import "from sqlalchemy.orm import relationship" should be placed before "from passlib.hash impo
> rt pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:31:0: C0411: third party import "from sqlalchemy.orm.exc import NoResultFound" should be placed before "from passlib.hash
>   import pbkdf2_sha512" (wrong-import-order)
> elbepack/db.py:32:0: C0411: third party import "from sqlalchemy.exc import OperationalError" should be placed before "from passlib.hash
> import pbkdf2_sha512" (wrong-import-order)
> 
> Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>

With the quotes fixed:
Reviewed-by: Bastian Germann <bage at linutronix.de>

> ---
>   elbepack/db.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/db.py b/elbepack/db.py
> index caaf8aa3c..f9b0cd40a 100644
> --- a/elbepack/db.py
> +++ b/elbepack/db.py
> @@ -19,8 +19,6 @@ from contextlib import contextmanager
>   from urllib.parse import quote
>   from threading import Thread
>   
> -from passlib.hash import pbkdf2_sha512
> -
>   from sqlalchemy.ext.declarative import declarative_base
>   from sqlalchemy import (Column, ForeignKey)
>   from sqlalchemy import (Integer, String, Boolean, Sequence, DateTime)
> @@ -31,6 +29,8 @@ from sqlalchemy.orm import relationship
>   from sqlalchemy.orm.exc import NoResultFound
>   from sqlalchemy.exc import OperationalError
>   
> +from passlib.hash import pbkdf2_sha512
> +
>   from elbepack.elbeproject import ElbeProject
>   from elbepack.elbexml import (ElbeXML, ValidationMode)
>   from elbepack.dosunix import dos2unix
> 


More information about the elbe-devel mailing list