[elbe-devel] [PATCH 1/2] tests: simple-amd64-with-grub-uefi.xml: fix mkfs.vfat error

[Torben Hohn]

mkfs.vfat refuses to create a filesystem on a device without
a partition table. The loop device is created with the
proper offsets, and is in fact a partition, but this is not
recognized by mkfs.vfat.

-------------------------------------------------------------------
[CMD] mkfs.vfat  -n uefi /dev/loop0
mkfs.fat: warning - lowercase labels might not work properly with DOS or Windows
mkfs.vfat: Partitions or virtual mappings on device '/dev/loop0', not making filesystem (use -I to override)
mkfs.fat 4.1 (2017-01-24)
[CMD] mv "/var/cache/elbe/31a3b8f2-f71c-4cf6-8bf7-f61bc7877836/filesystems/0"/* "/var/cache/elbe/31a3b8f2-f71c-4cf6-8bf7-f61bc7877836/target/"
[ERROR] Build failed
Traceback (most recent call last):
  File "/var/cache/elbe/devel/elbepack/asyncworker.py", line 186, in execute
    skip_pbuild=self.skip_pbuilder)
  File "/var/cache/elbe/devel/elbepack/elbeproject.py", line 685, in build
    self.targetfs.part_target(self.builddir, grub_version, grub_fw_type)
  File "/var/cache/elbe/devel/elbepack/efilesystem.py", line 423, in part_target
    grub_fw_type)
  File "/var/cache/elbe/devel/elbepack/hdimg.py", line 595, in do_hdimg
    grub_fw_type)
  File "/var/cache/elbe/devel/elbepack/hdimg.py", line 473, in do_image_hd
    create_label(disk, part, ppart, fslabel, target, grub)
  File "/var/cache/elbe/devel/elbepack/hdimg.py", line 365, in create_label
    loopdev))
  File "/var/cache/elbe/devel/elbepack/shellhelper.py", line 258, in do
    raise CommandError(cmd, p.returncode)
elbepack.shellhelper.CommandError: Error: 1 returned from Command mkfs.vfat  -n uefi /dev/loop0
-------------------------------------------------------------------

Specify the suggested override -I via <mkfs> tag.

Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>
---
 tests/simple-amd64-with-grub-uefi.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/simple-amd64-with-grub-uefi.xml b/tests/simple-amd64-with-grub-uefi.xml
index 4169eefb4..33d5672d6 100644
--- a/tests/simple-amd64-with-grub-uefi.xml
+++ b/tests/simple-amd64-with-grub-uefi.xml
@@ -61,6 +61,7 @@
 				<mountpoint>/boot/efi</mountpoint>
 				<fs>
 					<type>vfat</type>
+					<mkfs>-I</mkfs>
 				</fs>
 			</bylabel>
 		</fstab>
-- 
2.20.1