[elbe-devel] [PATCH 03/10] check-build: fix interpreteropts splitting

Bastian Germann bage at linutronix.de
Fri May 7 10:18:45 CEST 2021


Am 06.05.21 um 14:55 schrieb Torben Hohn:
> somehow the splitting of the interpreter-opts does not work properly.
> 
> Since pexpect.spawn() also supports a single string, resort to
> not splitting the options string into a list, and just append
> it to the interpreter name.
> 
> Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>

Acked-by: Bastian Germann <bage at linutronix.de>

> ---
>   elbepack/commands/check-build.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/commands/check-build.py b/elbepack/commands/check-build.py
> index bb5591bf0..e3e5b227d 100644
> --- a/elbepack/commands/check-build.py
> +++ b/elbepack/commands/check-build.py
> @@ -427,7 +427,7 @@ class CheckImage(CheckBase):
>   
>               opts = os.path.expandvars(tag
>                                         .text("./interpreter-opts")
> -                                      .strip(' \t\n')).split(' ')
> +                                      .strip(' \t\n'))
>   
>               for candidate, action in [("login",  self.do_login),
>                                         ("serial", self.do_serial)]:
> @@ -475,7 +475,7 @@ class CheckImage(CheckBase):
>   
>       def do_comm(self, img_name, qemu, opts, comm):
>   
> -        child      = pexpect.spawn(qemu, opts)
> +        child      = pexpect.spawn(qemu + " " + opts)
>           transcript = []
>           ret        = 0
>   
> 


More information about the elbe-devel mailing list