[elbe-devel] [PATCH] finetuning: use archive option for CopyFrom/ToPartition

[Bastian Germann]

Am 30.10.21 um 11:26 schrieb John Ogness:
> All finetuning copy commands use -av except for the project
> finetuning commands. There are many situations where the -a
> option is necessary (permissions, directories, symlinks,
> device nodes).
> 
> Use -av for the project finetuning partition copy commands.
> 
> Signed-off-by: John Ogness <john.ogness at linutronix.de>

Reviewed-by: Bastian Germann <bage at linutronix.de>

> ---
>   elbepack/finetuning.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/finetuning.py b/elbepack/finetuning.py
> index 9a2fcf075..f70115314 100644
> --- a/elbepack/finetuning.py
> +++ b/elbepack/finetuning.py
> @@ -668,7 +668,7 @@ class CopyFromPartition(ImageFinetuningAction):
>                                self.node.et.text, len(fname))
>                   raise FinetuningException('Patter matches too many files')
>   
> -            cmd = 'cp "%s" "%s"' % (fname[0], os.path.join(builddir, aname))
> +            cmd = 'cp -av "%s" "%s"' % (fname[0], os.path.join(builddir, aname))
>               do(cmd)
>   
>               target.images.append(aname)
> @@ -693,7 +693,7 @@ class CopyToPartition(ImageFinetuningAction):
>   
>           with ImgMountFilesystem(img_mnt, device) as mnt_fs:
>               fname = mnt_fs.fname(self.node.et.text)
> -            cmd = 'cp "%s" "%s"' % (os.path.join(builddir, aname), fname)
> +            cmd = 'cp -av "%s" "%s"' % (os.path.join(builddir, aname), fname)
>               do(cmd)
>   
>   @FinetuningAction.register('set_partition_type')
> 
> base-commit: c931652b2bd967c3069d80750dcf10bf79997f4b
>