[elbe-devel] [PATCH v3 02/16] schema: copy_from_partition: Add attributes

[Bastian Germann]

Am 23.09.22 um 16:03 schrieb Viraj Shah:
> * Add missing attributes for documentation of finetuning action
> "copy_from_partition".
> * Replace indents with spaces.
> 
> Signed-off-by: Viraj Shah <viraj.shah at linutronix.de>
> ---
>   schema/dbsfed.xsd | 24 ++++++++++++++++++------
>   1 file changed, 18 insertions(+), 6 deletions(-)
> 
> diff --git a/schema/dbsfed.xsd b/schema/dbsfed.xsd
> index 16325a8c2..495ed2665 100644
> --- a/schema/dbsfed.xsd
> +++ b/schema/dbsfed.xsd
> @@ -2394,16 +2394,28 @@
>     <complexType name="copy_from_partition">
>       <annotation>
>         <documentation>
> -        Attribute 'part' describes the partition to be mounted (nr).
> -	The value of the tag describes the filename to be copied from the
> -	Filesystem, after it has been mounted.
> -	Attribute 'artifact' is the artifact name.
> +        Using "copy_from partition", user gets an opportunity to copy a file

the user (missing article)

> +        from a partition and save it as an atrifact in the build output.

Typo: artifact

> +        This element's content is the file's path mentioned in the "part"
> +        partition.
>         </documentation>
>       </annotation>
>       <simpleContent>
>         <extension base="rfs:string">
> -        <attribute name="part" type="integer" use="required" />
> -        <attribute name="artifact" type="string" use="required" />
> +        <attribute name="part" type="integer" use="required">
> +         <annotation>
> +          <documentation>
> +           Describes the partition to which the required file belongs to.

Duplicate "to". The one at the end is more idiomatic. Remove the first one.

> +          </documentation>
> +         </annotation>
> +        </attribute>
> +        <attribute name="artifact" type="string" use="required">
> +         <annotation>
> +          <documentation>
> +           The name of the file that needs to be extracted is termed as an "artifact".
> +          </documentation>
> +         </annotation>
> +        </attribute>
>         </extension>
>       </simpleContent>
>     </complexType>

With the suggested changes:
Reviewed-by: Bastian Germann <bage at linutronix.de>