[elbe-devel] [PATCH] elbepack: drop option --nesting

[Thomas Weißschuh]

On Thu, Apr 25, 2024 at 09:49:28AM +0200, Benedikt Spranger wrote:
> On Wed, 24 Apr 2024 17:15:47 +0200
> Thomas Weißschuh <thomas.weissschuh at linutronix.de> wrote:
> 
> > The --nesting option enables running the initvm within another vm.
> > This is achieved by telling libvirt to pass through the full host CPU to
> > the initvm.
> > Otherwise libvirt would refuse to start the VM as the virtual CPU would
> > not fulfill the requirements of its generic guest CPU.
> > 
> > Using a generic guest CPU is useful when migrating VMs between different
> > hosts. But in the context of an elbe initvm this is an edge case that
> > requires manual steps anyway.
> > 
> > More users are confused by the failure to start an initvm inside an
> > existing VM.
> > 
> > So just completely remove the option.
> >
> > If we want to properly support both behaviours, the --nesting one should
> > be the default.
> I triped over the last two sentences. Maybe something along the line:
> 
> So default to the --nested behaviour and completely remove the option.
> 
> Generic CPU support may be added in the future as an optional feature.

I'll use that.

> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
> 
> But in any way:
> Reviewed-by: Benedikt Spranger <b.spranger at linutronix.de>

Thanks!