[elbe-devel] [PATCH 00/10] tree-wide: drop unnecessary constructors

Eduard Krein eduard.krein at linutronix.de
Fri Apr 26 15:51:38 CEST 2024


Am Montag, dem 22.04.2024 um 18:37 +0200 schrieb Thomas Weißschuh:
> The explicit constructors do the same as the implicit ones.
> 
> Except that they
>   * duplicate default parameters.
>   * provide visual noise.
>   * distract from the actual logic.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
Reviewed-by: Eduard Krein <eduard.krein at linutronix.de>

for whole series
> ---
> Thomas Weißschuh (10):
>       elbepack: finetuning: drop unnecessary constructors
>       elbepack: asyncworker: drop unnecessary constructors
>       elbepack: updatepkg: drop unnecessary constructors
>       elbepack: treeutils: drop unnecessary constructors
>       elbepack: soapclient: drop unnecessary constructors
>       elbepack: projectmanager: drop unnecessary constructors
>       elbepack: pbuilderaction: drop unnecessary constructors
>       elbepack: initvmaction: drop unnecessary constructors
>       elbepack: efilesystem: drop unnecessary constructors
>       elbepack: dbaction: drop unnecessary constructors
> 
>  elbepack/asyncworker.py    | 14 --------
>  elbepack/dbaction.py       | 48 -------------------------
>  elbepack/efilesystem.py    |  5 +--
>  elbepack/finetuning.py     | 90 ------------------------------------
> ----------
>  elbepack/initvmaction.py   | 21 +----------
>  elbepack/pbuilderaction.py | 12 +------
>  elbepack/projectmanager.py |  6 ++--
>  elbepack/soapclient.py     | 81 ------------------------------------
> -----
>  elbepack/treeutils.py      |  2 --
>  elbepack/updatepkg.py      |  3 +-
>  10 files changed, 6 insertions(+), 276 deletions(-)
> ---
> base-commit: 9d8411747148c0bc88935c39f13387fcae5238fb
> change-id: 20240422-finetuning-a46acc850fc6
> 
> Best regards,

-- 
Eduard Krein
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 19; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/legal/data-protection.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen |
Registergericht (Registration Court): Amtsgericht Freiburg i.Br.,
HRB700 806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas
Gleixner, Tiffany Silva, Sean Fennelly, Jeffrey Schneiderman






More information about the elbe-devel mailing list