[elbe-devel] [PATCH 07/22] elbepack: projectmanager: avoid cache indirection in update_pbuilder()

Thomas Weißschuh thomas.weissschuh at linutronix.de
Wed Aug 14 15:29:21 CEST 2024


The target project is already available, there is no need for the
indirection refetching it from the cache.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
---
 elbepack/daemons/soap/esoap.py | 3 +--
 elbepack/projectmanager.py     | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/elbepack/daemons/soap/esoap.py b/elbepack/daemons/soap/esoap.py
index f7e47aedcfae..269d328b12ca 100644
--- a/elbepack/daemons/soap/esoap.py
+++ b/elbepack/daemons/soap/esoap.py
@@ -211,8 +211,7 @@ class ESoap (ServiceBase):
     @rpc(String)
     @authenticated_uid
     def update_pbuilder(self, uid, builddir):
-        self.app.pm.open_project(uid, builddir)
-        self.app.pm.update_pbuilder(uid)
+        self.app.pm.update_pbuilder(uid, builddir)
 
     @rpc(String)
     @authenticated_uid
diff --git a/elbepack/projectmanager.py b/elbepack/projectmanager.py
index 84ff2cbcb7a0..4dfe58287e0a 100644
--- a/elbepack/projectmanager.py
+++ b/elbepack/projectmanager.py
@@ -187,9 +187,9 @@ class ProjectManager:
             self.worker.enqueue(BuildJob(ep, build_bin, build_src,
                                          skip_pbuilder))
 
-    def update_pbuilder(self, userid):
+    def update_pbuilder(self, userid, builddir):
+        ep = self.open_project(userid, builddir, allow_busy=False)
         with self.lock:
-            ep = self._get_current_project(userid, allow_busy=False)
             self.worker.enqueue(UpdatePbuilderJob(ep))
 
     def build_pbuilder(self, userid, cross, noccache, ccachesize):

-- 
2.46.0



More information about the elbe-devel mailing list