[elbe-devel] [PATCH 15/22] elbepack: projectmanager: avoid cache indirection in build_cdroms()

Thomas Weißschuh thomas.weissschuh at linutronix.de
Wed Aug 14 15:29:29 CEST 2024


The target project is already available, there is no need for the
indirection refetching it from the cache.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
---
 elbepack/daemons/soap/esoap.py | 3 +--
 elbepack/projectmanager.py     | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/elbepack/daemons/soap/esoap.py b/elbepack/daemons/soap/esoap.py
index 90f777a16226..447088d23c0c 100644
--- a/elbepack/daemons/soap/esoap.py
+++ b/elbepack/daemons/soap/esoap.py
@@ -190,8 +190,7 @@ class ESoap (ServiceBase):
     @rpc(String, Boolean, Boolean)
     @authenticated_uid
     def build_cdroms(self, uid, builddir, build_bin, build_src):
-        self.app.pm.open_project(uid, builddir)
-        self.app.pm.build_cdroms(uid, build_bin, build_src)
+        self.app.pm.build_cdroms(uid, builddir, build_bin, build_src)
 
     @rpc(String, Boolean, Boolean, Boolean)
     @authenticated_uid
diff --git a/elbepack/projectmanager.py b/elbepack/projectmanager.py
index ef2e1cf77422..261939304b03 100644
--- a/elbepack/projectmanager.py
+++ b/elbepack/projectmanager.py
@@ -248,9 +248,9 @@ class ProjectManager:
         with self.lock:
             self.worker.enqueue(BuildSDKJob(ep))
 
-    def build_cdroms(self, userid, build_bin, build_src):
+    def build_cdroms(self, userid, builddir, build_bin, build_src):
+        ep = self.open_project(userid, builddir, allow_busy=False)
         with self.lock:
-            ep = self._get_current_project(userid, allow_busy=False)
             self.worker.enqueue(BuildCDROMsJob(ep, build_bin, build_src))
 
     def build_update_package(self, userid, base_version):

-- 
2.46.0



More information about the elbe-devel mailing list