[elbe-devel] [PATCH 4/4] RFC: elbepack: add check-image-list/check-script XML element

[Benedikt Spranger]

On Thu, 23 May 2024 09:30:44 +0200
Thomas Weißschuh <thomas.weissschuh at linutronix.de> wrote:

A general notes upfront:
Even I introduced using type="string" for all kind of cargo loads, I
did not like it any more. My XML knowledge rised since then :)

I do not object (since we do it all over the place), but I would love
to see, if in can be revisited these parts and use types specified in 
https://www.w3.org/TR/xmlschema-2/

> The contents of the XML element define a test script which can be used
> to validate the result of an ELBE build.
> The script will be executed by "elbe check-build img".
> 
> To make authorship easier the path to a script can be specified in the
> "location" XML attribute and it will be inlined during preprocessing.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>

> diff --git a/elbepack/schema/dbsfed.xsd b/elbepack/schema/dbsfed.xsd
> index 380e16cc8c80..5fbe2e726c18 100644
> --- a/elbepack/schema/dbsfed.xsd
> +++ b/elbepack/schema/dbsfed.xsd
> @@ -553,10 +553,10 @@ SPDX-FileCopyrightText: Linutronix GmbH
>          Describes a sequence of check to be done on images.
>        </documentation>
>      </annotation>
> -    <sequence>
> -      <element name="check" type="rfs:check-img" minOccurs="0"
> maxOccurs="10">
> -      </element>
> -    </sequence>
> +    <choice minOccurs="0" maxOccurs="10">
I know it was there, but limit this to a abitrary 10 makes no sense to
me. But since it was there, no objection. On the other hand it would be
nice to have a commend here about the "why?".

> +      <element name="check" type="rfs:check-img" />
> +      <element name="check-script" type="rfs:check-script" />
> +    </choice>
>      <attributeGroup ref="xml:specialAttrs"/>
>    </complexType>

    Bene