[elbe-devel] [PATCH 6/8] elbepack: asyncworker: switch to non-shell syntax

Thomas Weißschuh thomas.weissschuh at linutronix.de
Wed May 15 13:32:22 CEST 2024


The shell syntax is error-prone and a mess of nested quoting syntax.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
---
 elbepack/asyncworker.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/elbepack/asyncworker.py b/elbepack/asyncworker.py
index f1149bbd3348..bf6d5e068557 100644
--- a/elbepack/asyncworker.py
+++ b/elbepack/asyncworker.py
@@ -448,10 +448,11 @@ class SaveVersionJob(AsyncWorkerJob):
 
         if self.project.savesh_file:
             logging.info('save version script:')
-            do((f'{self.project.savesh_file} "{self.project.builddir} '
-                f'{self.project.xml.text("project/version")} '
-                f'{self.project.xml.text("project/name")}"'
-                ), check=False)
+            do([
+                self.project.savesh_file, self.project.builddir,
+                self.project.xml.text('project/version'),
+                self.project.xml.text('project/name'),
+            ], check=False)
 
         logging.info('Enqueueing project to save package archive')
         AsyncWorkerJob.enqueue(self, queue, db)

-- 
2.45.0



More information about the elbe-devel mailing list