[elbe-devel] [PATCH 8/8] elbepack: updatepkg: switch to non-shell syntax

Thomas Weißschuh thomas.weissschuh at linutronix.de
Wed May 15 13:32:24 CEST 2024


The shell syntax is error-prone and a mess of nested quoting syntax.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
---
 elbepack/updatepkg.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/elbepack/updatepkg.py b/elbepack/updatepkg.py
index ab0391823a16..2ade83eeb723 100644
--- a/elbepack/updatepkg.py
+++ b/elbepack/updatepkg.py
@@ -139,6 +139,8 @@ def gen_update_pkg(project, xml_filename, upd_filename,
 
     if project.postbuild_file:
         logging.info('Postbuild script')
-        cmd = (f' "{upd_filename} {project.xml.text("project/version")} '
-               f'{project.xml.text("project/name")}"')
-        do(project.postbuild_file + cmd, check=False)
+        do([
+            project.postbuild_file,
+            upd_filename, project.xml.text('project/version'),
+            project.xml.text('project/name'),
+        ], check=False)

-- 
2.45.0



More information about the elbe-devel mailing list