[elbe-devel] [PATCH] elbepack: isooptions: fix cdrom options with subprocess module

Thomas Weißschuh thomas.weissschuh at linutronix.de
Mon Sep 16 10:12:54 CEST 2024


With the switch to the subprocess module, the options should have been
switched to an argv-style array instead of strings.
This also gets rid of the adhoc string formatting and escaping.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
---
 elbepack/isooptions.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/elbepack/isooptions.py b/elbepack/isooptions.py
index 1bb5c0bd3d69..05e5ad132ddd 100644
--- a/elbepack/isooptions.py
+++ b/elbepack/isooptions.py
@@ -45,6 +45,6 @@ def get_iso_options(xml):
             continue
         option = iso_options[node.tag]
         logging.info('Adding option %s\n%s', node.tag, option[2])
-        text = node.et.text[:option[1]]
-        options.append('%s "%s"' % (option[0], text.replace('"', '\\"')))
+        options.append(option[0])
+        options.append(node.et.text[:option[1]])
     return options

---
base-commit: 53a860fd35f97b7223902a3b06a8e969a57e829e
change-id: 20240916-cdrom-options-41302227e6d0

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh at linutronix.de>



More information about the elbe-devel mailing list