[elbe-devel] [PATCH] initvmaction: -oUserKnownHostFile=/dev/null removed to avoid

[Thomas Weißschuh]

Hello Martin,

thanks for your patch, unfortunately it seems it got corrupted.
The subject is truncated and is missing the reason for the change.
Also there is no commit message.
If this is a general issue with your companies mail setup, feel free to just
send missing descriptions as a normal email and I will build a commit out of it.

This SSH argument is useful as each re-creation of the initvm generates new
hostkeys which would trip up the SSH peer validation.
In general the "elbe initvm sync" command is meant solely for the development
of ELBE itself, so security considerations should not affect it.


Regards,
Thomas

On Mon, Feb 17, 2025 at 08:26:51AM +0000, Steih, Martin wrote:
> Signed-off-by: Steih, Martin martin.steih at lachmann-rink.de<mailto:martin.steih at lachmann-rink.de>
> ---
> elbepack/initvmaction.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/elbepack/initvmaction.py b/elbepack/initvmaction.py
> index 8f2c750b..9b2c7194 100644
> --- a/elbepack/initvmaction.py
> +++ b/elbepack/initvmaction.py
> @@ -400,7 +400,7 @@ def _submit(args):
> def _sync(args):
>      top_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
>      excludes = ['.git*', '*.pyc', 'elbe-build*', 'initvm', '__pycache__', 'docs', 'examples']
> -    ssh = ['ssh', '-p', str(args.sshport), '-oUserKnownHostsFile=/dev/null']
> +    ssh = ['ssh', '-p', str(args.sshport)]
>      subprocess.run([
>          'rsync', '--info=name1,stats1', '--archive', '--times',
>          *[arg for e in excludes for arg in ('--exclude', e)],
> --
> 2.39.5
> 
> i. A. Martin Steih
> Projektleiter
> Entwicklung