[elbe-devel] [PATCH 0/4] Add support for targetsdk-pkg-list

[Thomas Weißschuh]

Hi Martin,

On Wed, Feb 19, 2025 at 03:38:21PM +0100, martinsteih at gmx.de wrote:
> From: "Steih, Martin" <martin.steih at lachmann-rink.de>
> 
> Similar to  hostsdk-pkg-list, targetsdk-pkg-list provides a mechanism to
> install packages that are needed at build time (like static, or header-only
> libraries) to the sdk, without installing these packages into the target file
> system.  This keeps the target rfs smaller, and cleaner without the need of
> finetuning removals.  At the same time, we can keep all packages for one
> project in one xml-file.

Thanks for your patches!
I'll give them a closer look next week.

Could you fold the whole series into one patch?
I prefer to have all the parts together.
Also currently all the background is only mentioned in the cover letter which
will not be part of the commits. So all this information would be lost.

Also please create a feature entry under newsfragments/.
See the git history of that directory for examples.

> Tests run with this patches:
> * elbe initvm submit --build-sdk my_project.xml
> * The same using elbe control commands in a series
> 
> In each case, the packages appeared in the target sysroot, but not in host sysroot or the target rfs itself.
> The licences where added to licence-sysroot-target.*, but not to licence-sysroot-host.* or licence-target.*
> 
> Steih, Martin (4):
>   dbsfed: targetsdk-pkg-list added as xml element
>   xmlpreprocess: target/targetsdk-pkg-list added to lists to merge if
>     given multiple times
>   schema/dbsfed: clarification added to the targetsdk-pkg-list tag
>   elbeproject: add targetsdk packages to target sysroot
> 
>  elbepack/elbeproject.py    | 45 ++++++++++++++++++++++++++++----------
>  elbepack/schema/dbsfed.xsd |  9 ++++++++
>  elbepack/xmlpreprocess.py  |  1 +
>  3 files changed, 44 insertions(+), 11 deletions(-)