[elbe-devel] [PATCH 07/10] elbepack: soap: remove authentication
Thomas Weißschuh
thomas.weissschuh at linutronix.de
Fri Feb 28 14:59:18 CET 2025
The user management is going away.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
---
debian/python3-elbe-soap.install | 1 -
elbepack/daemons/soap/authentication.py | 102 -------------------------
elbepack/daemons/soap/esoap.py | 30 --------
newsfragments/+soap-authentication.removal.rst | 1 +
4 files changed, 1 insertion(+), 133 deletions(-)
diff --git a/debian/python3-elbe-soap.install b/debian/python3-elbe-soap.install
index 1220a09a4d65e59f51330e1d577992b2acc10627..02393f86e5e671ebfed27d8e685fcea7ba137f66 100644
--- a/debian/python3-elbe-soap.install
+++ b/debian/python3-elbe-soap.install
@@ -1,4 +1,3 @@
usr/lib/python3.*/*-packages/elbepack/daemons/soap/__init__.py
-usr/lib/python3.*/*-packages/elbepack/daemons/soap/authentication.py
usr/lib/python3.*/*-packages/elbepack/daemons/soap/datatypes.py
usr/lib/python3.*/*-packages/elbepack/daemons/soap/esoap.py
diff --git a/elbepack/daemons/soap/authentication.py b/elbepack/daemons/soap/authentication.py
deleted file mode 100644
index c14f5c96dc74120748579275f32dca7ac37e47bd..0000000000000000000000000000000000000000
--- a/elbepack/daemons/soap/authentication.py
+++ /dev/null
@@ -1,102 +0,0 @@
-# ELBE - Debian Based Embedded Rootfilesystem Builder
-# SPDX-License-Identifier: GPL-3.0-or-later
-# SPDX-FileCopyrightText: 2015-2018 Linutronix GmbH
-
-from functools import wraps
-
-from spyne.model.fault import Fault
-
-
-class SoapElbeNotLoggedIn(Fault):
- def __init__(self):
- super().__init__(
- faultcode='ElbeNotLoggedIn',
- faultstring='Not authenticated ! '
- 'Cant let you perform this command.')
-
-
-def authenticated(func):
- """ decorator, which Checks, that the current session is logged in.
-
- Allows for being wrapped in a soapmethod...
-
- Example:
- @soapmethod (String, _returns=Array(SoapFile))
- @authenticated
- def get_files (self, builddir):
- """
-
- # Do not edit this code. Although using *args is tempting here,
- # it will not work because Spyne is doing introspection on the
- # function's signature. I think it would be possible to do
- # something with func.__code__.replace, but this requires deep
- # Python's internal knowledges.
-
- if func.__code__.co_argcount == 2:
- @wraps(func)
- def wrapped(self):
- s = self.transport.req_env['beaker.session']
- try:
- s['userid']
- except KeyError:
- raise SoapElbeNotLoggedIn()
-
- return func(self)
- return wrapped
- if func.__code__.co_argcount == 3:
- @wraps(func)
- def wrapped(self, arg1):
- s = self.transport.req_env['beaker.session']
- try:
- s['userid']
- except KeyError:
- raise SoapElbeNotLoggedIn()
-
- return func(self, arg1)
- return wrapped
- if func.__code__.co_argcount == 4:
- @wraps(func)
- def wrapped(self, arg1, arg2):
- s = self.transport.req_env['beaker.session']
- try:
- s['userid']
- except KeyError:
- raise SoapElbeNotLoggedIn()
-
- return func(self, arg1, arg2)
- return wrapped
- if func.__code__.co_argcount == 5:
- @wraps(func)
- def wrapped(self, arg1, arg2, arg3):
- s = self.transport.req_env['beaker.session']
- try:
- s['userid']
- except KeyError:
- raise SoapElbeNotLoggedIn()
-
- return func(self, arg1, arg2, arg3)
- return wrapped
- if func.__code__.co_argcount == 6:
- @wraps(func)
- def wrapped(self, arg1, arg2, arg3, arg4):
- s = self.transport.req_env['beaker.session']
- try:
- s['userid']
- except KeyError:
- raise SoapElbeNotLoggedIn()
-
- return func(self, arg1, arg2, arg3, arg4)
- return wrapped
- if func.__code__.co_argcount == 7:
- @wraps(func)
- def wrapped(self, arg1, arg2, arg3, arg4, arg5):
- s = self.transport.req_env['beaker.session']
- try:
- s['userid']
- except KeyError:
- raise SoapElbeNotLoggedIn()
-
- return func(self, arg1, arg2, arg3, arg4, arg5)
- return wrapped
-
- raise Exception(f'arg count {func.__code__.co_argcount} not implemented')
diff --git a/elbepack/daemons/soap/esoap.py b/elbepack/daemons/soap/esoap.py
index 7ec4e899a62c8313af9244545c25f5b93984bbf4..3a86d8688659ecafc58821da3e3ebacbd619d901 100644
--- a/elbepack/daemons/soap/esoap.py
+++ b/elbepack/daemons/soap/esoap.py
@@ -21,7 +21,6 @@ from elbepack.elbexml import ValidationError, ValidationMode
from elbepack.projectmanager import InvalidState, ProjectManagerError
from elbepack.version import elbe_version
-from .authentication import authenticated
from .datatypes import SoapFile, SoapProject
@@ -93,23 +92,19 @@ class ESoap (ServiceBase):
return True
@rpc(_returns=Array(SoapProject))
- @authenticated
def list_projects(self):
return self.app.pm.db.list_projects()
@rpc(String, _returns=SoapProject)
- @authenticated
def get_project(self, builddir):
return self.app.pm.db.get_project_data(builddir)
@rpc(String, _returns=Array(SoapFile))
- @authenticated
def get_files(self, builddir):
files = self.app.pm.db.get_project_files(builddir)
return files
@rpc(String, String, String, Integer, _returns=Integer)
- @authenticated
def upload_file(self, builddir, fname, blob, part):
fn = os.path.join(builddir, fname)
@@ -138,43 +133,35 @@ class ESoap (ServiceBase):
return part + 1
@rpc(String)
- @authenticated
def build_chroot_tarball(self, builddir):
self.app.pm.build_chroot_tarball(builddir)
@rpc(String)
- @authenticated
def build_sysroot(self, builddir):
self.app.pm.build_sysroot(builddir)
@rpc(String)
- @authenticated
def build_sdk(self, builddir):
self.app.pm.build_sdk(builddir)
@rpc(String, Boolean, Boolean)
- @authenticated
def build_cdroms(self, builddir, build_bin, build_src):
self.app.pm.build_cdroms(builddir, build_bin, build_src)
@rpc(String, Boolean, Boolean, Boolean)
- @authenticated
def build(self, builddir, build_bin, build_src, skip_pbuilder):
self.app.pm.build_project(builddir, build_bin, build_src, skip_pbuilder)
@rpc(String, Boolean, Boolean, String)
- @authenticated
def build_pbuilder(self, builddir, cross, noccache, ccachesize):
self.app.pm.build_pbuilder(builddir, cross, noccache, ccachesize)
@rpc(String)
- @authenticated
def update_pbuilder(self, builddir):
self.app.pm.update_pbuilder(builddir)
@rpc(String)
- @authenticated
def start_cdrom(self, builddir):
cdrom_fname = os.path.join(builddir, 'uploaded_cdrom.iso')
@@ -183,7 +170,6 @@ class ESoap (ServiceBase):
fp.close()
@rpc(String, String)
- @authenticated
def append_cdrom(self, builddir, data):
cdrom_fname = os.path.join(builddir, 'uploaded_cdrom.iso')
@@ -193,12 +179,10 @@ class ESoap (ServiceBase):
fp.close()
@rpc(String)
- @authenticated
def finish_cdrom(self, builddir):
self.app.pm.set_upload_cdrom(builddir, ValidationMode.NO_CHECK)
@rpc(String)
- @authenticated
def start_pdebuild(self, builddir):
pdebuild_fname = os.path.join(builddir, 'current_pdebuild.tar.gz')
@@ -207,7 +191,6 @@ class ESoap (ServiceBase):
fp.close()
@rpc(String, String)
- @authenticated
def append_pdebuild(self, builddir, data):
pdebuild_fname = os.path.join(builddir, 'current_pdebuild.tar.gz')
@@ -217,17 +200,14 @@ class ESoap (ServiceBase):
fp.close()
@rpc(String, String, Boolean)
- @authenticated
def finish_pdebuild(self, builddir, profile, cross):
self.app.pm.build_pdebuild(builddir, profile, cross)
@rpc(String, String)
- @authenticated
def start_upload_orig(self, builddir, fname):
self.app.pm.set_orig_fname(builddir, fname)
@rpc(String, String)
- @authenticated
def append_upload_orig(self, builddir, data):
orig_fname = os.path.join(builddir, self.app.pm.get_orig_fname(builddir))
@@ -237,7 +217,6 @@ class ESoap (ServiceBase):
fp.close()
@rpc(String)
- @authenticated
def finish_upload_orig(self, builddir):
# If we support more than one orig, we need to put the orig_files into
# some list here.
@@ -245,17 +224,14 @@ class ESoap (ServiceBase):
pass
@rpc(String)
- @authenticated
def reset_project(self, builddir):
self.app.pm.db.reset_project(builddir, True)
@rpc(String)
- @authenticated
def del_project(self, builddir):
self.app.pm.del_project(builddir)
@rpc(String, String, _returns=String)
- @authenticated
def create_project(self, xml, url_validation):
with NamedTemporaryFile() as fp:
fp.write(binascii.a2b_base64(xml))
@@ -266,12 +242,10 @@ class ESoap (ServiceBase):
return prjid
@rpc(_returns=String)
- @authenticated
def new_project(self):
return self.app.pm.new_project()
@rpc(String, _returns=String)
- @authenticated
def get_project_busy(self, builddir):
ret, msg = self.app.pm.project_is_busy(builddir)
if not msg and not ret:
@@ -279,12 +253,10 @@ class ESoap (ServiceBase):
return msg
@rpc(String)
- @authenticated
def rm_log(self, builddir):
self.app.pm.rm_log(builddir)
@rpc(String, _returns=String.customize(max_occurs='unbounded'))
- @authenticated
def list_packages(self, builddir):
r = []
for _, _, filenames in os.walk(
@@ -294,7 +266,6 @@ class ESoap (ServiceBase):
return sorted(r)
@rpc(String, String)
- @authenticated
def tar_prjrepo(self, builddir, filename):
with tarfile.open(os.path.join(builddir, filename), 'w:gz') as tar:
tar.add(
@@ -304,6 +275,5 @@ class ESoap (ServiceBase):
builddir, 'repo')))
@rpc(String, String)
- @authenticated
def include_package(self, builddir, filename):
self.app.pm.add_deb_package(builddir, filename)
diff --git a/newsfragments/+soap-authentication.removal.rst b/newsfragments/+soap-authentication.removal.rst
new file mode 100644
index 0000000000000000000000000000000000000000..b2e099d4afc4b22156ae5ab7cc70fbe50354671d
--- /dev/null
+++ b/newsfragments/+soap-authentication.removal.rst
@@ -0,0 +1 @@
+The authentication of the SOAP interface has been removed.
--
2.48.1
More information about the elbe-devel
mailing list