[elbe-devel] build successful but producing broken image (error in .xml)

Manuel Traut manuel.traut at linutronix.de
Tue Nov 22 14:10:44 CET 2016


Hi,
 
> this is an "observation" more than anything else.
> 
> I changed the file system labels in the <target><images>...
> section. I FORGOT to change them in the <target><fstab>...
> section.

there is no validation for this at the moment. Also we have
no sanity checks for image/partition sizes, ..

Feel free to send patches that add checks like this to
'elbepack/elbexml.py' if you throw a ValidationError
this should be handled correctly and _early_. :)

> What happened is this: The build finished successfully.
> However, the resulting image could not be loop mounted
> (kpartx, mount ...). I did not dig further, to find what
> was really broken.
> 
> Imho it is ok to produce a broken image if I screw the
> build description. It would be nicer imho, if the build
> failed right away. But I have no idea, how to catch this,
> because the xml is well-formed, in this particular case.
> 
> On the other hand, this problem will surface at the next
> boot anyway.
> 
> 
> Cheers,
> Erich
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 

------------------------------------------------
Linutronix GmbH

fon +49 7556 25999 16

Firmensitz: D-88690 Uhldingen, Bahnhofstraße 3
Registergericht: Freiburg i. Br., HRB 700 806;
Geschäftsführer: Heinz Egger, Thomas Gleixner




More information about the elbe-devel mailing list