[elbe-devel] [PATCH 08/13] elbeproject: always validate binary repos

[Manuel Traut]

On Wed, Dec 06, 2017 at 01:10:11PM +0100, Torben Hohn wrote:
> On Wed, Dec 06, 2017 at 11:02:23AM +0100, Manuel Traut wrote:
> > On Wed, Dec 06, 2017 at 10:49:29AM +0100, Torben Hohn wrote:
> > > On Thu, Nov 30, 2017 at 03:15:10PM +0100, Manuel Traut wrote:
> > > > it makes no sense, to only validate the repos if a bin-cdrom.iso
> > > > should be generated. The repos are also needed to build the RFS.
> > > 
> > > I also question, why source repos shall not be validated ?
> > >
> > > if i specify a repository in the xml it must be validatet.
> > > no matter if i skip source building, or not.
> > >
> > > Before this ValidationMode was introduced, we had a flag,
> > > that would skip Repo Validation altogether.
> > > (This was added, because Repo Validation was not perfect, and we needed
> > > to be able to skip it. Considering, that we currently still cant
> > > validate httpredir, we need to be able to skip URL Validation. I dont
> > > see why we have to make distinctions here)
> > 
> > I'm fine with that for url-list repos. But i've no idea how to decide if it's
> > an error if the primary_mirror has sources or not.
> 
> I would say, that primary mirror should "normally" contain the sources.
> The last step before a Release is a Build with sources enabled.
> I believe, that it makes perfect sense to warn in "binary-only quick"
> builds about missing sources, because then the release process will not
> have a "suprise" that sources can not be found.

It could be a warning if the sources are missing if they are not needed for
a specific build.

The validation code was just made to warn people if they have a typo in their
URLs. I don't want that --skip-url-check is used by everybody because url
validation is to strict.