[elbe-devel] [PATCH 05/25] pylint: initvmaction: remove unused wdfs global variable and parameter

Torben Hohn torben.hohn at linutronix.de
Wed Aug 22 10:42:06 CEST 2018


pylint complains:
elbepack/initvmaction.py:38: [W0621(redefined-outer-name), ensure_outdir] Redefining name 'wdfs' from outer scope (line 17)
elbepack/initvmaction.py:38: [W0613(unused-argument), ensure_outdir] Unused argument 'wdfs'

fix it by removing the unused parameter and also the unused import

Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>
---
 elbepack/initvmaction.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/elbepack/initvmaction.py b/elbepack/initvmaction.py
index 0935c6d7..cb7ec866 100644
--- a/elbepack/initvmaction.py
+++ b/elbepack/initvmaction.py
@@ -14,7 +14,7 @@ import elbepack
 from elbepack.treeutils import etree
 from elbepack.directories import elbe_exe
 from elbepack.shellhelper import CommandError, system, command_out_stderr
-from elbepack.filesystem import wdfs, TmpdirFilesystem
+from elbepack.filesystem import TmpdirFilesystem
 from elbepack.elbexml import ElbeXML, ValidationError, ValidationMode
 from elbepack.config import cfg
 
@@ -35,7 +35,7 @@ def cmd_exists(x): return any(os.access(os.path.join(path, x), os.X_OK)
 # if necessary
 
 
-def ensure_outdir(wdfs, opt):
+def ensure_outdir(opt):
     if opt.outdir is None:
         opt.outdir = "elbe-build-%s" % (
                 datetime.datetime.now().strftime("%Y%m%d-%H%M%S"))
@@ -515,7 +515,7 @@ class CreateAction(InitVMAction):
                 print("Getting generated Files")
                 print("")
 
-                ensure_outdir(wdfs, opt)
+                ensure_outdir(opt)
 
                 try:
                     system('%s control get_files --output "%s" "%s"' % (
@@ -722,7 +722,7 @@ class SubmitAction(InitVMAction):
                 print("Getting generated Files")
                 print("")
 
-                ensure_outdir(wdfs, opt)
+                ensure_outdir(opt)
 
                 try:
                     system('%s control get_files --output "%s" "%s"' % (
-- 
2.11.0




More information about the elbe-devel mailing list