[elbe-devel] [PATCH v2 40/66] hdimg: Fix Pylint

Olivier Dion dion at linutronix.de
Wed Jun 10 15:42:48 CEST 2020


On Wed, 10 Jun 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:

>> -            # Replace groot and kopt because
>> -            # else they will be given bad values
>> -            do('chroot %s sed -in "s/^# groot=.*$/# groot=\(hd0,%d\)/" %s' %
>> +            # Replace groot and kopt because else they will be given
>> +            # bad values
>> +            #
>> +            # FIXME - Pylint says: Using possibly undefined loop variable
>> +            # 'entry' (undefined-loop-variable).  entry is defined in
>> +            # the previous for-loop.
>> +            # # pylint: disable=undefined-loop-variable
>
> i dont think, you have fixed this.  We can fix this later.  But dont
> ignore a pylint error, that is a real Problem.

Indeed, I did not yet.  I'll keep the FIXME and remove the pylint
disabling for now?

-- 
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen



More information about the elbe-devel mailing list