[elbe-devel] [PATCH v2 40/66] hdimg: Fix Pylint

[Torben Hohn]

On Wed, Jun 10, 2020 at 09:42:48AM -0400, Olivier Dion wrote:
> On Wed, 10 Jun 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:
> 
> >> -            # Replace groot and kopt because
> >> -            # else they will be given bad values
> >> -            do('chroot %s sed -in "s/^# groot=.*$/# groot=\(hd0,%d\)/" %s' %
> >> +            # Replace groot and kopt because else they will be given
> >> +            # bad values
> >> +            #
> >> +            # FIXME - Pylint says: Using possibly undefined loop variable
> >> +            # 'entry' (undefined-loop-variable).  entry is defined in
> >> +            # the previous for-loop.
> >> +            # # pylint: disable=undefined-loop-variable
> >
> > i dont think, you have fixed this.  We can fix this later.  But dont
> > ignore a pylint error, that is a real Problem.
> 
> Indeed, I did not yet.  I'll keep the FIXME and remove the pylint
> disabling for now?

yes.

then:

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> 
> -- 
> Olivier Dion
> Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner